Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart BotKube pod if configmap is updated #72

Closed
PrasadG193 opened this issue Mar 28, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@PrasadG193
Copy link
Member

commented Mar 28, 2019

Is your feature request related to a problem? Please describe.
BotKube pod should be automatically restarted if someone edits the botkube-configmap in runtime so that BotKube controller starts using with the updated config. This will reduce effort of redeploying complete BotKube stack just for minor configuration changes

Describe the solution you'd like
We already have informers registered to watch lifecycle events of resources, we can catch changes in botkube-configmap and exit if is is updated. Deployment controller will automatically create a new BotKube pod.

@PrasadG193 PrasadG193 modified the milestone: v1.0.0 Mar 29, 2019

@ssudake21 ssudake21 removed this from the v1.0.0 milestone Mar 29, 2019

@PrasadG193

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

We are using https://github.com/fsnotify/fsnotify to get local file change events instead of handling k8s configmap events.

@PrasadG193 PrasadG193 closed this Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.