Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image tag in Helm chart should be configurable #88

Closed
bhavin192 opened this issue May 9, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@bhavin192
Copy link
Contributor

commented May 9, 2019

Is your feature request related to a problem? Please describe.
If we build BotKube image for some bug fix or want to use image with a tag like latest then one should be able to set that image tag while installing BotKube with Helm chart.

Describe the solution you'd like
Changing the version from Chart.yaml is not a clean solution, also it won't allow to set it to tag values which are not according to sem ver 2. We should have .Values.image.tag

https://helm.sh/docs/developing_charts/#charts-and-versioning

@bhavin192

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

Fixed by #89

@bhavin192 bhavin192 closed this May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.