Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1

Merged
merged 27 commits into from Dec 31, 2018
Merged

Develop #1

merged 27 commits into from Dec 31, 2018

Conversation

@sanketsudake
Copy link
Member

@sanketsudake sanketsudake commented Dec 26, 2018

No description provided.

Gopkg.toml Outdated Show resolved Hide resolved
Loading
README.md Outdated Show resolved Hide resolved
Loading
_, controller := cache.NewInformer(
watchlist,
&apiV1.Event{},
30*time.Minute,
Copy link
Member Author

@sanketsudake sanketsudake Dec 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this configurable.

Loading

return printDefaultMsg()
}
if args[1] == "start" {
config.Notify = true
Copy link
Member Author

@sanketsudake sanketsudake Dec 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add log messages here both in notify start/stop

Loading

}
_, err := ValidServicePort(serviceName, ns, int32(servicePort))
if err != nil {
event.Messages = append(event.Messages, "Warning: Service "+serviceName+" used in ingress config does not exist or port not exposed\n")
Copy link
Member Author

@sanketsudake sanketsudake Dec 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Warning:
Message level already indicates it

Loading

attachment.Color = attachmentColor[event.Level]
params.Attachments = []slack.Attachment{attachment}

log.Logger.Infof("Sending message on %v with token %s", s.Channel, s.Token)
Copy link
Member Author

@sanketsudake sanketsudake Dec 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid logging unwanted info . Credentials etc.
Sending message on channel %s

Loading

@sanketsudake sanketsudake merged commit 383711f into master Dec 31, 2018
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants