Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1

Merged
merged 27 commits into from Dec 31, 2018

Conversation

Projects
None yet
2 participants
@ssudake21
Copy link
Member

commented Dec 26, 2018

No description provided.

@PrasadG193 PrasadG193 force-pushed the develop branch from 8f54e05 to c4ad77d Dec 26, 2018

PrasadG193 added some commits Dec 26, 2018

Show resolved Hide resolved Gopkg.toml Outdated
Show resolved Hide resolved README.md Outdated

@PrasadG193 PrasadG193 force-pushed the develop branch from 9bebff5 to f23c1ef Dec 31, 2018

@PrasadG193 PrasadG193 force-pushed the develop branch from f23c1ef to 8052353 Dec 31, 2018

PrasadG193 added some commits Dec 31, 2018

_, controller := cache.NewInformer(
watchlist,
&apiV1.Event{},
30*time.Minute,

This comment has been minimized.

Copy link
@ssudake21

ssudake21 Dec 31, 2018

Author Member

Make this configurable.

return printDefaultMsg()
}
if args[1] == "start" {
config.Notify = true

This comment has been minimized.

Copy link
@ssudake21

ssudake21 Dec 31, 2018

Author Member

add log messages here both in notify start/stop

}
_, err := ValidServicePort(serviceName, ns, int32(servicePort))
if err != nil {
event.Messages = append(event.Messages, "Warning: Service "+serviceName+" used in ingress config does not exist or port not exposed\n")

This comment has been minimized.

Copy link
@ssudake21

ssudake21 Dec 31, 2018

Author Member

Remove Warning:
Message level already indicates it

attachment.Color = attachmentColor[event.Level]
params.Attachments = []slack.Attachment{attachment}

log.Logger.Infof("Sending message on %v with token %s", s.Channel, s.Token)

This comment has been minimized.

Copy link
@ssudake21

ssudake21 Dec 31, 2018

Author Member

avoid logging unwanted info . Credentials etc.
Sending message on channel %s

@ssudake21 ssudake21 merged commit 383711f into master Dec 31, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.