Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add Support Go Modules, Remove dep dependencies #141

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@codenio
Copy link
Contributor

@codenio codenio commented Aug 2, 2019

ISSUE TYPE
  • Feature Pull Request
SUMMARY

This Commit,

  • migrates the dependencies management from deb to go modules.
  • Gopkg.lock and Gopkg.toml of dep removed and go.mod and go.sum of modules added
  • replaces dep endure with go mod verify .travis.yaml
  • updates vendor dependencies using go mod tidy,go mod verify and go mod vendor commands
  • replaces github.com/google/go-github/github with github.com/google/go-github/v27/github for go module support in pkg/controller/upgrade.go

Fixes #137

Migrated Botkube from dep to go modules with the following reference

This Commit,
- migrates the dependencies management from deb to go modules.
- `Gopkg.lock` and `Gopkg.toml` of dep removed and  `go.mod` and `go.sum` of modules added 
- replaces `dep endure` with `go mod verify` .travis.yaml
- updates vendor dependencies using `go mod tidy`,`go mod verify` and `go mod vendor` commands
- replaces `github.com/google/go-github/github` with `github.com/google/go-github/v27/github` for go module support in `pkg/controller/upgrade.go`
@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Aug 5, 2019

Thanks for the PR @aananthraj !

@PrasadG193 PrasadG193 merged commit 5013c3b into infracloudio:develop Aug 5, 2019
1 check passed
@codenio codenio deleted the feature/go-modules branch Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants