Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unit test] Enable Unit test and add target in Makefile #145

Merged
merged 2 commits into from Aug 8, 2019

Conversation

@codenio
Copy link
Contributor

@codenio codenio commented Aug 8, 2019

ISSUE TYPE
  • Feature Pull Request
SUMMARY

This PR

  • Adds make target to run unit tests
  • Enable unit test check in travis

Signed-off-by: Shovan Maity shovan.cse91@gmail.com

Patched

  • Rebased imazik:enable-unit-test onto infracloudio:develop
  • adds unit-test to make release

Signed-off-by: Aananth K aananthraj1995@gmail.com

Fixes #144

This PR
- Adds make target to run unit tests
- Enable unit test check in travis
Signed-off-by: Shovan Maity <shovan.cse91@gmail.com>
@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Aug 8, 2019

Should we also run unit tests when we make git-tag?

git-tag:

@codenio
Copy link
Contributor Author

@codenio codenio commented Aug 8, 2019

Should we also run unit tests when we make git-tag?

during a release.?
Do we have any seperate use case for git-tag excluding release.?

release: check-git-status container-image tag-image publish git-tag

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Aug 8, 2019

Nope, we can add it in release also.

This commit
- Just rebased this PR onto infracloudio:develop 
- adds `unit-test` to `make release`

Signed-off-by: Aananth K <aananthraj1995@gmail.com>
@codenio codenio force-pushed the feature/enable-unit-test branch from 598802e to 414e9f3 Aug 8, 2019
@codenio
Copy link
Contributor Author

@codenio codenio commented Aug 8, 2019

added unit-test to make release

@PrasadG193 PrasadG193 merged commit d2d14cc into infracloudio:develop Aug 8, 2019
1 check passed
@codenio codenio deleted the feature/enable-unit-test branch Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants