Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E Integration tests #154

Merged
merged 4 commits into from Aug 26, 2019
Merged

Conversation

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Aug 13, 2019

ISSUE TYPE
  • Feature Pull Request
SUMMARY

This PR:

  • Adds E2E integration test framework
  • Refactors Slack notifier to use latest nlopes/slack
  • Refactor Bot implementations to work with mocked Slack
  • Add CommandRunner interface and fake_executor to mock kubectl command execution
  • Add warnings field to the Event struct
  • Update filter recommendation message format
  • Rename hack/unit-test.sh to hack/runtests.sh
  • Modify make target unit-test to test

To Run:
go test -tags=test ./test/e2e/ -v OR ./hack/runtests.sh OR make test

Fixes #136

@PrasadG193 PrasadG193 force-pushed the integration-tests branch 2 times, most recently from e22d9de to 36ecb9e Aug 19, 2019
PrasadG193 added 2 commits Aug 24, 2019
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193 PrasadG193 force-pushed the integration-tests branch 2 times, most recently from c834d0b to 35a3988 Aug 26, 2019
Add CommandRunner interface and fake_executor to mock kubectl command execution
Add warnings field to the Event struct
Update filter recommendation message format

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193 PrasadG193 force-pushed the integration-tests branch from 35a3988 to b1d71a6 Aug 26, 2019
@PrasadG193 PrasadG193 marked this pull request as ready for review Aug 26, 2019
@PrasadG193 PrasadG193 changed the title WIP: Add E2E Integration tests Add E2E Integration tests Aug 26, 2019
@PrasadG193
Copy link
Member Author

@PrasadG193 PrasadG193 commented Aug 26, 2019

Negative tests are yet to be added, will raise separate PR for that

Rename hack/unit-test.sh to hack/runtests.sh
Modify make target unit-test to test

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193 PrasadG193 force-pushed the integration-tests branch from b1d71a6 to 5f0f456 Aug 26, 2019
@PrasadG193 PrasadG193 merged commit 7d6dd8d into infracloudio:develop Aug 26, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants