Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proxyURL, deployment env variable if-loop #156

Merged
merged 3 commits into from Aug 20, 2019

Conversation

@rajinator
Copy link
Contributor

@rajinator rajinator commented Aug 15, 2019

ISSUE TYPE
  • Feature Pull Request
SUMMARY

Adding Support for Basic Proxy

Need a proxy configured to use the proxy value. If statement in deployment.yaml will make sure deployment doesn't fail, if proxy is not being used

Fixes #155

@bhavin192
Copy link
Contributor

@bhavin192 bhavin192 commented Aug 16, 2019

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Aug 17, 2019

@bhavin192 sounds good to me. @rajinator could you please make those changes?

@rajinator
Copy link
Contributor Author

@rajinator rajinator commented Aug 18, 2019

@PrasadG193 @bhavin192 @sanketsudake changes added, also added new issues #160 and #161

@PrasadG193 PrasadG193 merged commit 6db72e1 into infracloudio:develop Aug 20, 2019
1 check passed
@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Aug 20, 2019

PR merged, thanks @rajinator !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants