Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Update Events with resource spec diff and Change event message formats #158

Merged
merged 2 commits into from Aug 18, 2019

Conversation

@codenio
Copy link
Contributor

@codenio codenio commented Aug 17, 2019

ISSUE TYPE
  • Feature Pull Request
SUMMARY

This PR,

  • enhances update event notifications with details of what Spec is getting changed
  • adds custom SpecDiffReporter and utils.Diff() method.
  • adds update events in all config.yaml files
  • excludes namespace field from namespace independent resource events

Fixes #131

Preview

0

Fixes #135

Preview

1

Fixes excludes namespace field from namespace independent resource events

Preview

  • secret being namespaced gets namespace field
    3
@codenio codenio force-pushed the feature/update-events branch from c26e9ad to b804b3c Aug 17, 2019
config.yaml Outdated Show resolved Hide resolved
@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Aug 17, 2019

@aananthraj could you please also verify if JobStatusChecker filter runs and we get Job Succeeded notification on the creation of Job resource (when configured with update event)

@codenio codenio force-pushed the feature/update-events branch from b804b3c to dcf2492 Aug 18, 2019
@codenio
Copy link
Contributor Author

@codenio codenio commented Aug 18, 2019

@PrasadG193, Resolved those issues 👍

@codenio codenio force-pushed the feature/update-events branch from dcf2492 to 99fe4e2 Aug 18, 2019
codenio added 2 commits Aug 18, 2019
This Commit
- includes namespace field only for namespaced objects notifs
- excludes namespace field from namespace independent resource events
This Commit,
- enhances update event notifications with details of what Spec is getting changed
- adds custom `SpecDiffReporter` and `utils.Diff()` method.
- adds update events in all config.yaml files
- adds unit-test for utils.Diff()
- adds update events for Deployment, Statefulset and Job by default.
@codenio codenio force-pushed the feature/update-events branch from 99fe4e2 to 4dc0051 Aug 18, 2019
@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Aug 18, 2019

Awesome! Great work @aananthraj 🎉

@PrasadG193 PrasadG193 merged commit 1f9efd6 into infracloudio:develop Aug 18, 2019
1 check passed
@codenio codenio deleted the feature/update-events branch Aug 18, 2019
@codenio
Copy link
Contributor Author

@codenio codenio commented Aug 18, 2019

Thanks for the excellent support @PrasadG193 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants