Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Level Critical Events filter #159

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@codenio
Copy link
Contributor

@codenio codenio commented Aug 18, 2019

ISSUE TYPE
  • Feature Pull Request
SUMMARY

This PR,

  • Allows kubernetes events of Warning Type as ErrorEvents
  • Allows kubernetes events of Normal Type as Insignificant InfoEvents
  • Adds NodeEventsChecker filter to check for Node InfoEvents with critical reasons like NodeNotReady ,NodeReady.
  • InfoEvents with critical reasons are promoted as significant Node ErrorEvents
  • Post events filtering, unpromoted Insignificant InfoEvents are skipped.

Fixes #134

Preview
node-event-filter

@codenio codenio force-pushed the feature/node-event-filter branch 2 times, most recently from d76e4e7 to ff21d65 Aug 18, 2019
@codenio
Copy link
Contributor Author

@codenio codenio commented Aug 18, 2019

rebased onto develop

pkg/controller/controller.go Outdated Show resolved Hide resolved
@codenio codenio force-pushed the feature/node-event-filter branch 2 times, most recently from 9b26385 to c0deccc Aug 19, 2019
@codenio codenio force-pushed the feature/node-event-filter branch from c0deccc to 1bd7087 Aug 20, 2019
@codenio
Copy link
Contributor Author

@codenio codenio commented Aug 20, 2019

rebased onto develop.
I guess it is ready, Let's get this merged.

pkg/events/events.go Outdated Show resolved Hide resolved
pkg/filterengine/filters/node_event_checker.go Outdated Show resolved Hide resolved
@codenio codenio force-pushed the feature/node-event-filter branch from 1bd7087 to a1b6a2a Aug 20, 2019
This Commit
- Allows  kubernetes events of `Warning` Type as ErrorEvents
- Allows kubernetes events of `Normal` Type as Insignificant InfoEvents
- Adds `NodeEventsChecker` filter to check for Node InfoEvents with critical reasons like `NodeNotReady` ,`NodeReady`.
- InfoEvents with critical reasons are promoted as significant Node ErrorEvents
- Post events filtering, unpromoted Insignificant `InfoEvents` are skipped.
@codenio codenio force-pushed the feature/node-event-filter branch from a1b6a2a to e465f94 Aug 20, 2019
@PrasadG193 PrasadG193 merged commit fa9c205 into infracloudio:develop Aug 21, 2019
1 check passed
@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Aug 21, 2019

Merged. Thanks @aananthraj !

@codenio
Copy link
Contributor Author

@codenio codenio commented Aug 21, 2019

@PrasadG193 thanks for the support 👍

@codenio codenio deleted the feature/node-event-filter branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants