Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rebased] Feature/generic ssl #163

Merged
merged 6 commits into from Aug 26, 2019

Conversation

@rajinator
Copy link
Contributor

@rajinator rajinator commented Aug 22, 2019

ISSUE TYPE
  • Feature Pull Request
SUMMARY

Make custom SSL/TLS support generic, instead of just mattermost. Useful for clusters using self-signed certificates or infrastructure behind SSL proxies in enterprise

Applicable changes for #160

Rebased according to @bhavin192's request

helm/botkube/values.yaml Outdated Show resolved Hide resolved
helm/botkube/templates/deployment.yaml Outdated Show resolved Hide resolved
helm/botkube/templates/deployment.yaml Outdated Show resolved Hide resolved
helm/botkube/templates/secret.yaml Outdated Show resolved Hide resolved
@bhavin192 bhavin192 requested a review from mugdha-adhav Aug 23, 2019
Copy link
Contributor

@bhavin192 bhavin192 left a comment

LGTM for now!

@bhavin192
Copy link
Contributor

@bhavin192 bhavin192 commented Aug 26, 2019

@mugdha-adhav can you please take a look at this change once and approve if it looks good to you, just to make sure everything is fine.

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Aug 26, 2019

Thanks for the PR @rajinator !

@PrasadG193 PrasadG193 merged commit a9e03af into infracloudio:develop Aug 26, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants