Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialised filters and minor issues #173

Merged
merged 1 commit into from Sep 1, 2019

Conversation

@codenio
Copy link
Contributor

@codenio codenio commented Sep 1, 2019

ISSUE TYPE
  • Bug fix Pull Request
SUMMARY

This PR,

  • fixes uninitialized filters (NamespaceChecker, ObjectAnnotationChecker) by moving them out of respective directories.
  • updates expected values in test/.../botkube.go
  • removes repetitive assert in test/.../create.go
This Commit, 
- fixes uninitialized filters (NamespaceChecker, ObjectAnnotationChecker) by moving them out of respective directories.
- updates expected values in test/.../botkube.go
- removes repetitive assert in test/.../create.go
@codenio codenio force-pushed the bugfix/minor-fixes branch from c5e53f3 to cd0cb53 Sep 1, 2019
@codenio
Copy link
Contributor Author

@codenio codenio commented Sep 1, 2019

rebased onto develop

@PrasadG193 PrasadG193 merged commit 9b8e252 into infracloudio:develop Sep 1, 2019
1 check passed
@codenio codenio deleted the bugfix/minor-fixes branch Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants