Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Test Suits #174

Merged
merged 1 commit into from Sep 3, 2019
Merged

Conversation

@codenio
Copy link
Contributor

@codenio codenio commented Sep 2, 2019

ISSUE TYPE
  • Feature Pull Request
SUMMARY

This PR,

  • Refactors test suites to support granular integration testing
  • adds dedicated config file test/config.yaml to control integration testing of notifiers.
  • changes CONFIG_PATH to pwd/test in /hack/runtest.sh to make use of test/config.yaml
  • adds go vet -tags=test ./test/... to ./hack/verify-govet.sh
@codenio codenio force-pushed the feature/refactor-tests branch from 1facb0f to a04f038 Sep 2, 2019
@codenio
Copy link
Contributor Author

@codenio codenio commented Sep 2, 2019

rebased onto develop

@codenio codenio mentioned this pull request Sep 2, 2019
test/e2e/command/botkube.go Outdated Show resolved Hide resolved
@codenio codenio force-pushed the feature/refactor-tests branch from a04f038 to 90bc4bb Sep 3, 2019
This Commit, 
- Refactors test suites to support granular integration testing
- adds dedicated config file `test/config.yaml` to control integration testing of notifiers.
- changes CONFIG_PATH to `pwd/test` in /hack/runtest.sh to make use of test/config.yaml
- adds `go vet -tags=test  ./test/...` to `./hack/verify-govet.sh`
@codenio codenio force-pushed the feature/refactor-tests branch from 90bc4bb to 615afa3 Sep 3, 2019
@codenio
Copy link
Contributor Author

@codenio codenio commented Sep 3, 2019

resolved requested changes. It is ready now. Let's get this merged.

@PrasadG193 PrasadG193 merged commit 30d8ac1 into infracloudio:develop Sep 3, 2019
1 check passed
@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Sep 3, 2019

Merged! Thanks for the PR @codenio

@codenio codenio deleted the feature/refactor-tests branch Sep 3, 2019
@codenio
Copy link
Contributor Author

@codenio codenio commented Sep 3, 2019

Thanks for the prompt responses @PrasadG193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants