Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate notification for Job update #187

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Oct 8, 2019

ISSUE TYPE
  • Bug fix Pull Request
SUMMARY

This PR fixes the issue of getting duplicate Job update notifications.
We'll be ignoring update events which are older than 30sec

@PrasadG193 PrasadG193 requested a review from sanketsudake Oct 8, 2019
pkg/controller/controller.go Outdated Show resolved Hide resolved
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193 PrasadG193 force-pushed the fix-dup-update-event branch from fe1e4cb to daea4e9 Oct 8, 2019
codenio
codenio approved these changes Oct 8, 2019
Copy link
Contributor

@codenio codenio left a comment

LGTM 👍

@PrasadG193
Copy link
Member Author

@PrasadG193 PrasadG193 commented Oct 9, 2019

Thanks @codenio for reviewing and suggesting changes.

@PrasadG193 PrasadG193 merged commit dc29e0c into infracloudio:develop Oct 9, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants