Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster scoped resource notification issue #221

Merged
merged 4 commits into from Nov 23, 2019

Conversation

PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Nov 23, 2019

ISSUE TYPE
  • Bug fix Pull Request
SUMMARY
  • Don't skip notification for cluster scoped resources
  • Move message formatting logic to notif package
  • Remove secret resource from default BotKube config
  • Fix notification previews in Slack and MM

Fixes #218

PrasadG193 added 4 commits Nov 23, 2019
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Fix previews in Slack & Mattermost notifications

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193 PrasadG193 changed the title Format notif Fix cluster scoped resource notification issue Nov 23, 2019
@PrasadG193 PrasadG193 merged commit 3660b0d into infracloudio:develop Nov 23, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants