Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass communication settings as a k8s secret #233

Merged
merged 12 commits into from Dec 22, 2019

Conversation

slalwani97
Copy link
Contributor

@slalwani97 slalwani97 commented Dec 19, 2019

Fixes #211

Signed-off-by: Sumit Lalwani sumit.lalwani97@gmail.com

slalwani97 added 11 commits Dec 2, 2019
Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Dec 19, 2019

@slalwani97 Please also split config.yaml placed here (https://github.com/infracloudio/botkube/blob/develop/config.yaml) into resource_config.yaml and comm_config.yaml and verify if you are able to run BotKube outside the cluster.
Steps to run BotKube outside the cluster:

  1. Build: go build ./cmd/botkube/
  2. Edit comm_config.yaml and add credentials
  3. Run binary

Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
@slalwani97
Copy link
Contributor Author

@slalwani97 slalwani97 commented Dec 19, 2019

sumit@sumit-ThinkPad-E490:~/go/src/github.com/infracloudio/botkube$ ./botkube
INFO[2019-12-19T17:35:09+05:30] Registering the filter ImageTagChecker       
INFO[2019-12-19T17:35:09+05:30] Registering the filter IngressValidator      
INFO[2019-12-19T17:35:09+05:30] Registering the filter JobStatusChecker      
INFO[2019-12-19T17:35:09+05:30] Registering the filter NamespaceChecker      
INFO[2019-12-19T17:35:09+05:30] Registering the filter NodeEventsChecker     
INFO[2019-12-19T17:35:09+05:30] Registering the filter ObjectAnnotationChecker 
INFO[2019-12-19T17:35:09+05:30] Registering the filter PodLabelChecker       
INFO[2019-12-19T17:35:09+05:30] Starting controller                          
INFO[2019-12-19T17:35:09+05:30] Starting upgrade notifier                    
INFO[2019-12-19T17:35:09+05:30] Allowed Events - map[{Resource:clusterrole Namespace:all EventType:create}:true {Resource:clusterrole Namespace:all EventType:delete}:true {Resource:clusterrole Namespace:all EventType:error}:true {Resource:clusterrolebinding Namespace:all EventType:create}:true {Resource:clusterrolebinding Namespace:all EventType:delete}:true {Resource:clusterrolebinding Namespace:all EventType:error}:true {Resource:configmap Namespace:all EventType:create}:true {Resource:configmap Namespace:all EventType:delete}:true {Resource:configmap Namespace:all EventType:error}:true {Resource:daemonset Namespace:all EventType:create}:true {Resource:daemonset Namespace:all EventType:delete}:true {Resource:daemonset Namespace:all EventType:error}:true {Resource:deployment Namespace:all EventType:create}:true {Resource:deployment Namespace:all EventType:delete}:true {Resource:deployment Namespace:all EventType:error}:true {Resource:deployment Namespace:all EventType:update}:true {Resource:ingress Namespace:all EventType:create}:true {Resource:ingress Namespace:all EventType:delete}:true {Resource:ingress Namespace:all EventType:error}:true {Resource:job Namespace:all EventType:create}:true {Resource:job Namespace:all EventType:delete}:true {Resource:job Namespace:all EventType:error}:true {Resource:job Namespace:all EventType:update}:true {Resource:namespace Namespace:all EventType:create}:true {Resource:namespace Namespace:all EventType:delete}:true {Resource:namespace Namespace:all EventType:error}:true {Resource:node Namespace:all EventType:create}:true {Resource:node Namespace:all EventType:delete}:true {Resource:node Namespace:all EventType:error}:true {Resource:persistentvolume Namespace:all EventType:create}:true {Resource:persistentvolume Namespace:all EventType:delete}:true {Resource:persistentvolume Namespace:all EventType:error}:true {Resource:persistentvolumeclaim Namespace:all EventType:create}:true {Resource:persistentvolumeclaim Namespace:all EventType:delete}:true {Resource:persistentvolumeclaim Namespace:all EventType:error}:true {Resource:pod Namespace:all EventType:create}:true {Resource:pod Namespace:all EventType:delete}:true {Resource:pod Namespace:all EventType:error}:true {Resource:role Namespace:all EventType:create}:true {Resource:role Namespace:all EventType:delete}:true {Resource:role Namespace:all EventType:error}:true {Resource:rolebinding Namespace:all EventType:create}:true {Resource:rolebinding Namespace:all EventType:delete}:true {Resource:rolebinding Namespace:all EventType:error}:true {Resource:secret Namespace:all EventType:create}:true {Resource:secret Namespace:all EventType:delete}:true {Resource:secret Namespace:all EventType:error}:true {Resource:service Namespace:all EventType:create}:true {Resource:service Namespace:all EventType:delete}:true {Resource:service Namespace:all EventType:error}:true {Resource:statefulset Namespace:all EventType:create}:true {Resource:statefulset Namespace:all EventType:delete}:true {Resource:statefulset Namespace:all EventType:error}:true {Resource:statefulset Namespace:all EventType:update}:true] 
INFO[2019-12-19T17:35:09+05:30] Registering resource lifecycle informer      
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:pod             
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:service         
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:deployment      
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:statefulset     
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:ingress         
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:node            
INFO[2019-12-19T17:35:09+05:30] Registering watcher on configfile resource_config.yaml 
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:namespace       
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:persistentvolume 
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:secret          
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:configmap       
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:daemonset       
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:job             
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:role            
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:rolebinding     
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:clusterrole     
INFO[2019-12-19T17:35:09+05:30] Adding informer for resource:clusterrolebinding 
INFO[2019-12-19T17:35:09+05:30] Registering kubernetes events informer for types: warning 
INFO[2019-12-19T17:35:09+05:30] Registering kubernetes events informer for types: normal 
ERRO[2019-12-19T17:35:10+05:30] pods "botkube-64c9b675f8-rrj9v" not found    
ERRO[2019-12-19T17:35:10+05:30] pods "botkube-64c9b675f8-rrj9v" not found

@PrasadG193 PrasadG193 merged commit a4a9328 into infracloudio:develop Dec 22, 2019
1 check passed
@firehist
Copy link

@firehist firehist commented Mar 5, 2020

Thanks a lot for this.
Do you have some plan about when this will be part of a new release on master?!

mergify bot pushed a commit that referenced this issue May 25, 2021
)

##### ISSUE TYPE
 - Feature Pull Request

##### SUMMARY
I have implemented in the helm chart the possibility to pass the communication config as a k8s secret and configure in the value files via an existingSecret. It can be configured in the values file via these:

```yaml
communications:
    existingSecret: false
    existingSecretName: ""
```

Fixes #319 #211 #226 #233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants