Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added restrictAccess flag to enable/disable behavior of botkube. #238

Merged
merged 1 commit into from Jan 1, 2020
Merged

Added restrictAccess flag to enable/disable behavior of botkube. #238

merged 1 commit into from Jan 1, 2020

Conversation

mahendrabagul
Copy link
Contributor

@mahendrabagul mahendrabagul commented Dec 27, 2019

This flag will control user's access to botkube via configured channel. If set to true, it will allow user to talk to botkube only through configured channel. In other case, botkube will be accessible from all channels.

Signed-off-by: Mahendra Bagul mahendra@infracloud.com

ISSUE TYPE
  • Bug fix Pull Request
SUMMARY

Fix for #235

pkg/execute/executor.go Outdated Show resolved Hide resolved
pkg/execute/executor.go Show resolved Hide resolved
… flag will control user's access to botkube via configured channel. If set to true, it will allow user to talk to botkube only through configured channel. In other case, botkube will be accessible from all channels.

Signed-off-by: Mahendra Bagul <bagulm123@gmail.com>

Fixed #238 (comment) issue. Removed msg and re-added the check required for not responding to non-kubectl commands

Signed-off-by: Mahendra Bagul <bagulm123@gmail.com>

Fixed a test case

Signed-off-by: Mahendra Bagul <bagulm123@gmail.com>

Fixed #238 (comment) issue. Removed msg and re-added the check required for not responding to non-kubectl commands

Signed-off-by: Mahendra Bagul <bagulm123@gmail.com>

Placed the condition at right place.

Signed-off-by: Mahendra Bagul <bagulm123@gmail.com>
@PrasadG193 PrasadG193 merged commit 75f77e7 into infracloudio:develop Jan 1, 2020
1 check passed
@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Jan 1, 2020

Merged! Thanks @mahendrabagul for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants