Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to make rbac rules and service account configurable #255

Merged
merged 5 commits into from Apr 15, 2020

Conversation

adusumillipraveen
Copy link
Contributor

@adusumillipraveen adusumillipraveen commented Apr 15, 2020

ISSUE TYPE
  • Feature Pull Request
SUMMARY

This will enhance helm chart giving ability for users to manage RBAC rules or use a different service account . This is to avoid botkube slack to have access to everything including secrets on slack .

The chart changes are non breaking and behave like older version with defaults set as before.

helm/botkube/values.yaml Outdated Show resolved Hide resolved
helm/botkube/values.yaml Outdated Show resolved Hide resolved
Co-Authored-By: Tim Jacomb <tim.jacomb@hmcts.net>
timja
timja approved these changes Apr 15, 2020
Copy link
Contributor

@timja timja left a comment

nice! secrets being accessible by default is not good imo

helm/botkube/Chart.yaml Outdated Show resolved Hide resolved
@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Apr 15, 2020

Thanks @adusumillipraveen for the PR and @timja for reviewing it.
As @timja suggested, @adusumillipraveen - could you please update the default rbac rules to exclude secrets?

Co-Authored-By: Prasad Ghangal <prasad.ghangal@gmail.com>
@adusumillipraveen
Copy link
Contributor Author

@adusumillipraveen adusumillipraveen commented Apr 15, 2020

Thanks @adusumillipraveen for the PR and @timja for reviewing it.
As @timja suggested, @adusumillipraveen - could you please update the default rbac rules to exclude secrets?

@PrasadG193 It is not easy to do that as it doesn't support set subtraction . So, we will need to list everything and it can become quite big. I would leave it to users to maintain it ?

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Apr 15, 2020

That's true. We already have an issue created to track this. Let's handle that separately

Co-Authored-By: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193 PrasadG193 merged commit f3e3931 into infracloudio:develop Apr 15, 2020
1 check passed
@adusumillipraveen
Copy link
Contributor Author

@adusumillipraveen adusumillipraveen commented Apr 15, 2020

Thanks @PrasadG193 . Are there any plans to release master anytime soon ? As the older images (v0.9.1) doesn't seem to be compatible with latest chart. Don't really want use latest tag.

@adusumillipraveen adusumillipraveen deleted the clusterrolevonfigurable branch Apr 15, 2020
@adusumillipraveen adusumillipraveen restored the clusterrolevonfigurable branch Apr 15, 2020
@adusumillipraveen adusumillipraveen deleted the clusterrolevonfigurable branch Apr 15, 2020
@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Apr 15, 2020

@adusumillipraveen We are trying to get Teams support in the next release. But it is being harder than we expected :). If we are not able to do it before next week, we'll probably do a minor release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants