Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm fixes #259

Merged
merged 1 commit into from Apr 21, 2020
Merged

helm fixes #259

merged 1 commit into from Apr 21, 2020

Conversation

eddycharly
Copy link
Contributor

@eddycharly eddycharly commented Apr 20, 2020

ISSUE TYPE
  • Bug fix Pull Request
SUMMARY

Fixing #257 and #258.

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Apr 20, 2020

Looks good. @eddycharly Could you please also update release script to overwrite the default image tag in values.yaml?
https://github.com/infracloudio/botkube/blob/develop/hack/release.sh#L27

@eddycharly
Copy link
Contributor Author

@eddycharly eddycharly commented Apr 20, 2020

How do you want to get this done ?

Here the chart version should be bumped but there’s no need to change the image version.

I mean the chart can evolve without changing the image (nodeSelector for exemple is only a chart concern).

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Apr 20, 2020

We have address the release script change in separate PR. We just need to add one more sed statement (like https://github.com/infracloudio/botkube/blob/develop/hack/release.sh#L31) to update the tag: in value.yaml

@eddycharly
Copy link
Contributor Author

@eddycharly eddycharly commented Apr 20, 2020

Let's say we create a v0.9.2 release, the version is extracted form the version tag.

How can we set the chart version to v0.9.2 and image tag to v0.9.1 ?
I don't see a way to decouple chart version and image tag.

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Apr 20, 2020

@eddycharly We do application and chart release at the same time with the same tag.

@eddycharly
Copy link
Contributor Author

@eddycharly eddycharly commented Apr 20, 2020

@PrasadG193 i made the requested changes in release.sh

hack/release.sh Outdated Show resolved Hide resolved
@eddycharly
Copy link
Contributor Author

@eddycharly eddycharly commented Apr 21, 2020

@PrasadG193 any chance to get a release soon ?

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Apr 21, 2020

@eddycharly We are working on adding/updating documentation. We should be able to release by this weekend

@PrasadG193 PrasadG193 merged commit 42e2947 into infracloudio:develop Apr 21, 2020
1 check passed
@eddycharly
Copy link
Contributor Author

@eddycharly eddycharly commented Apr 21, 2020

Thanks 👍

@eddycharly
Copy link
Contributor Author

@eddycharly eddycharly commented Apr 21, 2020

@PrasadG193 If it helps, you can use helm-docs to generate helm chart doc automatically.

I can open a PR for that if you're interested.

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Apr 24, 2020

@eddycharly That looks great. Let me see if I can automate the doc generation. BTW, we maintain documentation in a separate repo here: https://github.com/infracloudio/botkube-docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants