Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send bot start/stop messages to slack channel #3

Merged
merged 3 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@PrasadG193
Copy link
Member

commented Jan 2, 2019

Fixes: #2

  • Send bot start/stop messages to slack channel
  • Fix timestamps in delete notifications

PrasadG193 added some commits Jan 2, 2019

Fixes #2: Send bot start/stop messages to slack channel
- Fix timestamps in delete notifications

@PrasadG193 PrasadG193 changed the base branch from master to develop Jan 2, 2019

@PrasadG193 PrasadG193 requested a review from ssudake21 Jan 2, 2019


func sendMessage(msg string) {
if len(msg) <= 0 {
return

This comment has been minimized.

Copy link
@ssudake21

ssudake21 Jan 2, 2019

Member

log warning here

Show resolved Hide resolved pkg/execute/executor.go Outdated
notifier.SendEvent(event)
}

func sendMessage(msg string) {

This comment has been minimized.

Copy link
@ssudake21

ssudake21 Jan 2, 2019

Member

Keep this function in notifier package

This comment has been minimized.

Copy link
@PrasadG193

PrasadG193 Jan 3, 2019

Author Member

@ssudake21 we already have notifier.SendMessage(msg) function in notifier package

@PrasadG193 PrasadG193 force-pushed the fix-notification-msgs branch from 85ff313 to 0f6218c Jan 3, 2019

@ssudake21 ssudake21 merged commit 55f636f into develop Jan 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@PrasadG193 PrasadG193 deleted the fix-notification-msgs branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.