Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send bot start/stop messages to slack channel #3

Merged
merged 3 commits into from Jan 3, 2019

Conversation

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Jan 2, 2019

Fixes: #2

  • Send bot start/stop messages to slack channel
  • Fix timestamps in delete notifications
@PrasadG193 PrasadG193 changed the base branch from master to develop Jan 2, 2019
@PrasadG193 PrasadG193 requested a review from sanketsudake Jan 2, 2019

func sendMessage(msg string) {
if len(msg) <= 0 {
return
Copy link
Member

@sanketsudake sanketsudake Jan 2, 2019

log warning here

pkg/execute/executor.go Outdated Show resolved Hide resolved
notifier.SendEvent(event)
}

func sendMessage(msg string) {
Copy link
Member

@sanketsudake sanketsudake Jan 2, 2019

Keep this function in notifier package

Copy link
Member Author

@PrasadG193 PrasadG193 Jan 3, 2019

@ssudake21 we already have notifier.SendMessage(msg) function in notifier package

@PrasadG193 PrasadG193 force-pushed the fix-notification-msgs branch from 85ff313 to 0f6218c Jan 3, 2019
@sanketsudake sanketsudake merged commit 55f636f into develop Jan 3, 2019
2 checks passed
@PrasadG193 PrasadG193 deleted the fix-notification-msgs branch Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants