Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding icon so chart passes `helm lint` #31

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
4 participants
@adamhaney
Copy link
Contributor

commented Jan 31, 2019

Helm lint recommends that charts include an icon. I added one that was already hosted on the website

Helm Lint Output Before Change

➜  botkube git:(master) ✗ helm lint .
==> Linting .
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, no failures

Helm Lint Output After Change

➜  botkube git:(master) ✗ cat Chart.yaml 
apiVersion: v1
appVersion: "1.0"
description: A Helm chart for Kubernetes
icon: https://www.botkube.io/images/botkube.ico
name: botkube
version: 0.1.0


➜  botkube git:(master) ✗ helm lint .
==> Linting .
Lint OK

1 chart(s) linted, no failures

@ssudake21 ssudake21 requested review from PrasadG193 and ssudake21 Feb 1, 2019

@ssudake21 ssudake21 merged commit 2c42089 into infracloudio:master Feb 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bhavin192

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2019

Hey @adamhaney, thank you for your contribution 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.