Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mattermost #55

Merged
merged 1 commit into from Mar 29, 2019

Conversation

Projects
None yet
3 participants
@mugdha-adhav
Copy link
Member

commented Mar 14, 2019

No description provided.

@mugdha-adhav mugdha-adhav changed the title Issue #26: Design doc for Mattermost support WIP Issue #26: Design doc for Mattermost support Mar 19, 2019

Show resolved Hide resolved helm/botkube/values.yaml Outdated
Show resolved Hide resolved pkg/mattermost/mattermost.go Outdated
Show resolved Hide resolved pkg/controller/controller.go Outdated
Show resolved Hide resolved pkg/mattermost/mattermost.go Outdated
Show resolved Hide resolved Gopkg.lock
@ssudake21

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

@mugdha-adhav Lets rebase this once with PR #59 . Seeing lot of duplicate changes. Will check all changes in one go

@ssudake21 ssudake21 referenced this pull request Mar 25, 2019

Closed

Mattermost support #26

@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch 2 times, most recently from 82b1d0b to cccae3d Mar 25, 2019

@mugdha-adhav mugdha-adhav changed the title WIP Issue #26: Design doc for Mattermost support Add support for Mattermost Mar 25, 2019

@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch from cccae3d to 6f343f4 Mar 25, 2019

@PrasadG193

This comment has been minimized.

@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch from 6f343f4 to 616d80b Mar 26, 2019

@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch 2 times, most recently from 858b2d9 to fee50d0 Mar 27, 2019

@PrasadG193

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

@mugdha-adhav not a part of this PR, but could you please remove func formatAndSendLogs(rtm *slack.RTM, channelID, logs string, filename string) function, I don't think we need that anymore.
https://github.com/infracloudio/botkube/blob/master/pkg/slack/slack.go#L119

@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch from fee50d0 to 0fd452f Mar 28, 2019

Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated

@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch from 0fd452f to 71cd575 Mar 29, 2019

@ssudake21 ssudake21 merged commit 133af07 into develop Mar 29, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.