Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mattermost implementation changes for botkube channel. #76

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@mugdha-adhav
Copy link
Member

commented Apr 3, 2019

Removed CreateChannel support from Mattermost.
Formatted postMessage output.
Updated README for adding channel in Mattermost.

@mugdha-adhav mugdha-adhav requested a review from PrasadG193 Apr 3, 2019

@mugdha-adhav mugdha-adhav changed the title Mattermost implementation changes for botkube channel. WIP Mattermost implementation changes for botkube channel. Apr 3, 2019

@mugdha-adhav mugdha-adhav changed the title WIP Mattermost implementation changes for botkube channel. Mattermost implementation changes for botkube channel. Apr 3, 2019

Show resolved Hide resolved pkg/notify/mattermost.go Outdated
Show resolved Hide resolved pkg/notify/mattermost.go Outdated
Show resolved Hide resolved pkg/mattermost/mattermost.go Outdated
@PrasadG193

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

Please rebase with develop

@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch from 37ecf21 to 44bef18 Apr 4, 2019

@mugdha-adhav mugdha-adhav requested a review from ssudake21 Apr 4, 2019

Show resolved Hide resolved pkg/mattermost/mattermost.go
Show resolved Hide resolved config.yaml Outdated

@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch from 44bef18 to 77175dd Apr 4, 2019

Mattermost implementation changes for botkube channel.
Removed CreateChannel support from Mattermost.
Formatted postMessage output.
Updated README for adding channel in Mattermost.
Removed Fatal log calls in Controller
Modified log messages to print additional error information
Added comments for Mattermost config parameters.

@mugdha-adhav mugdha-adhav force-pushed the infracloudio/mattermost-support branch from 77175dd to 4ccff09 Apr 4, 2019

@PrasadG193 PrasadG193 merged commit cb22d4f into develop Apr 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bhavin192 bhavin192 referenced this pull request Apr 4, 2019

Closed

Mattermost support #26

@PrasadG193 PrasadG193 deleted the infracloudio/mattermost-support branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.