Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to manage filters with @BotKube command #84

Merged
merged 1 commit into from May 8, 2019

Conversation

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented Apr 30, 2019

fixes #71

Usage:

@BotKube filters list : list all filters
@Botkube filters disable <filter-name> : Disable perticular filter
@Botkube filters enable <filter-name> : Enable a filter

Next action items:

  • Update steps to create custom filter in botkube-docs
  • Update BotKube help with filter command documentation
@PrasadG193 PrasadG193 changed the base branch from master to develop Apr 30, 2019
@PrasadG193 PrasadG193 force-pushed the add-filters-commands branch 2 times, most recently from 11349e4 to 7b3e394 Apr 30, 2019
@PrasadG193 PrasadG193 force-pushed the add-filters-commands branch 2 times, most recently from bd6bd10 to 3ecd8f2 Apr 30, 2019
@PrasadG193
Copy link
Member Author

@PrasadG193 PrasadG193 commented Apr 30, 2019

Fixes: #71

pkg/execute/executor.go Outdated Show resolved Hide resolved
pkg/execute/executor.go Outdated Show resolved Hide resolved
pkg/execute/executor.go Outdated Show resolved Hide resolved
@PrasadG193 PrasadG193 force-pushed the add-filters-commands branch from 3ecd8f2 to 94cf36b Apr 30, 2019
@PrasadG193 PrasadG193 force-pushed the add-filters-commands branch from 94cf36b to 1bb594e May 4, 2019
@bhavin192
Copy link
Contributor

@bhavin192 bhavin192 commented May 6, 2019

Fixes: #71

Please follow the Pull Request template. Adding this to PR body will close the issue when this PR is merged.

@PrasadG193
Copy link
Member Author

@PrasadG193 PrasadG193 commented May 6, 2019

PrasadG193 changed the base branch from master to develop 6 days ago

I had raised PR against master and then changed base to develop, I think that's why it didn't provide me PR template

@bhavin192
Copy link
Contributor

@bhavin192 bhavin192 commented May 6, 2019

I had raised PR against master and then changed base to develop, I think that's why it didn't provide me PR template

Ah! no issues, we can just add fixes #num in the PR body for now, that will take care of closing the related issue ;)

@PrasadG193
Copy link
Member Author

@PrasadG193 PrasadG193 commented May 8, 2019

Raised PR to update documentation: infracloudio/botkube-docs#22

@PrasadG193 PrasadG193 merged commit c552848 into infracloudio:develop May 8, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants