Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm chart] make image tag configurable #89

Merged
merged 1 commit into from May 13, 2019

Conversation

@bhavin192
Copy link
Contributor

@bhavin192 bhavin192 commented May 9, 2019

  • If image.tag is set in values.yaml then that tag is used, otherwise
    falls back to Chart version
  • This makes easy to deploy images tagged with different names which
    are not according to sem ver 2 i.e. 'latest' or other valid
    container image tags

fixes #88

helm/botkube/values.yaml Show resolved Hide resolved
Loading
@bhavin192
Copy link
Contributor Author

@bhavin192 bhavin192 commented May 10, 2019

@ssudake21 @PrasadG193 should I address the changes suggested by rimusz in this PR (having appVersion in Chart.yaml) or should that be addressed in separate PR?

Loading

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented May 10, 2019

We can address those in the same PR

Loading

- Add appVersion field to Chart.yaml. Thanks to @rimusz for the
  suggestions about this
- If image.tag is set in values.yaml then that tag is used, otherwise
  falls back to appVersion from Chart.yaml
- This makes easy to deploy images tagged with different names which
  are not according to sem ver 2 i.e. 'latest' or other valid
  container image tags

Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
@bhavin192 bhavin192 requested review from sanketsudake and PrasadG193 and removed request for sanketsudake May 10, 2019
@bhavin192 bhavin192 mentioned this pull request May 10, 2019
@PrasadG193 PrasadG193 merged commit cef9c24 into infracloudio:develop May 13, 2019
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants