Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis CI] don't push container image for PR builds #94

Merged
merged 1 commit into from May 17, 2019

Conversation

@bhavin192
Copy link
Contributor

@bhavin192 bhavin192 commented May 17, 2019

ISSUE TYPE
  • Bug fix Pull Request
SUMMARY
- Makes sure that image on Docker hub is updated only for commits to
  develop branch and not for PRs
- ref:
  https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
@sanketsudake
Copy link
Member

@sanketsudake sanketsudake commented May 17, 2019

LGTM.Please go ahead and merge. Thanks for quick fix.

@PrasadG193
Copy link
Member

@PrasadG193 PrasadG193 commented May 17, 2019

Thanks @bhavin192 for catching and fixing this

@PrasadG193 PrasadG193 merged commit 8017492 into infracloudio:develop May 17, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants