Skip to content

Conversation

@pleimer
Copy link
Contributor

@pleimer pleimer commented Jun 3, 2021

These instructions are for OSP16.1+

Reorganized the deployment instructions so that steps involved in deployment of the grafana operator using the STO are verified in the same section separately from the section showing how to deploy the dashboards.

Added mention of the rhos-cloud-dashboard and deployment instructions. Implemented warning that the following configuration is required in stf-connectors.yaml for this dashboard to fully function:

parameter_defaults:
    ExtraConfig:
        collectd::plugin::virt::hostname_format: name uuid hostname

@pleimer
Copy link
Contributor Author

pleimer commented Jun 3, 2021

Copy link
Member

@leifmadsen leifmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good Paul, thanks! Just a couple minor edits. We'll let Joanne review and modify next week (she is out today). Likely she will fix some of my style :)

pleimer and others added 7 commits June 4, 2021 11:45
…a-to-host-the-dashboard.adoc

Co-authored-by: Leif Madsen <lmadsen@redhat.com>
…a-to-host-the-dashboard.adoc

Co-authored-by: Leif Madsen <lmadsen@redhat.com>
…a-to-host-the-dashboard.adoc

Co-authored-by: Leif Madsen <lmadsen@redhat.com>
…a-to-host-the-dashboard.adoc

Co-authored-by: Leif Madsen <lmadsen@redhat.com>
…a-to-host-the-dashboard.adoc

Co-authored-by: Leif Madsen <lmadsen@redhat.com>
…a-to-host-the-dashboard.adoc

Co-authored-by: Leif Madsen <lmadsen@redhat.com>
…a-to-host-the-dashboard.adoc

Co-authored-by: Leif Madsen <lmadsen@redhat.com>
Copy link
Collaborator

@JoanneOFlynn2018 JoanneOFlynn2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Paul! Just one comment to address.
Bank holiday here today so I'll be online again this evening to approve :)

Copy link
Member

@leifmadsen leifmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks really great to me. Let's get it merged!

@JoanneOFlynn2018 JoanneOFlynn2018 merged commit 4c4f4eb into master Jun 8, 2021
@JoanneOFlynn2018 JoanneOFlynn2018 deleted the dashboard-updates branch June 8, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants