FIX: ensure sklearn and spark tfidf compatibility for sklearn >= 1.5 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaak
force-pushed
the
copy_skl14_tfidf
branch
2 times, most recently
from
3f891b8 to
102cc91
Compare
… skl>=1.5 Change for TfidfTransformer of sklearn v1.5 in order to ensure compatibility between the pandas and spark version of emm. In sklearn v1.5+ TfidfTransformer no longer has the _idf_diag attribute, needed for setting the compatibility.
mbaak
force-pushed
the
copy_skl14_tfidf
branch
from
fa3c136 to
1c8f1cc
Compare
mbaak
changed the title
twalen
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: we are using sklearn v1.4.2 of TfidfTransformer in order to ensure compatibility between the
pandas and spark version of emm. In sklearn v1.5+ TfidfTransformer no longer has the _idf_diag attribute,
needed for the compatibility.