Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update playwright, make test suite work #1623

Merged
merged 2 commits into from Mar 16, 2022
Merged

chore: update playwright, make test suite work #1623

merged 2 commits into from Mar 16, 2022

Conversation

narzac
Copy link
Contributor

@narzac narzac commented Mar 14, 2022 •
edited

What I did

  1. Update playwright and test dependencies to the latest and make test suite work
  2. Skip failing tests only on the browsers that the test fails, to be investigated later in case they persist
  3. Fix check for CSS typed object in OverlayController

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2022 •
edited

🦋 Changeset detected

Latest commit: 565a204

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/overlays Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@narzac narzac force-pushed the chore/fix-test-suite branch 3 times, most recently from 95897a7 to 8b785a8 Compare March 16, 2022 10:22
@narzac narzac merged commit d46b989 into master Mar 16, 2022
@narzac narzac deleted the chore/fix-test-suite branch March 16, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlouisse tlouisse tlouisse approved these changes

@daKmoR daKmoR Awaiting requested review from daKmoR daKmoR is a code owner

@gerjanvangeest gerjanvangeest Awaiting requested review from gerjanvangeest gerjanvangeest is a code owner

@erikkroes erikkroes Awaiting requested review from erikkroes erikkroes is a code owner

@ruphin ruphin Awaiting requested review from ruphin ruphin is a code owner

@Knorgias Knorgias Awaiting requested review from Knorgias Knorgias is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@narzac @tlouisse