fix(core): use partial renderOptions in SlotMixin (for Safari) #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlouisse
requested review from
daKmoR,
gerjanvangeest,
erikkroes,
ruphin,
narzac and
Knorgias
as code owners
🦋 Changeset detectedLatest commit: c01cfe9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tlouisse
force-pushed
the
fix/templateSlotMixinSafari
branch
from
debc4ea
to
c01cfe9
Compare
|
strange - but ok... it's safari 🤷♂️ |
daKmoR
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure that safari doesn't throw an error when ScopedElementsMixin renderOptions are used for "offline" render of nodes.
(was not possible to test this without loading the polyfill)