feat(switch): fix error caused by setting role in constructor (fixes #1740) #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riovir
requested review from
tlouisse,
daKmoR,
gerjanvangeest,
erikkroes,
ruphin,
narzac and
Knorgias
as code owners
🦋 Changeset detectedLatest commit: 7b930a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jorenbroekema
approved these changes
Jul 5, 2022
Co-authored-by: jorenbroekema <joren.broekema@gmail.com>
jorenbroekema
force-pushed
the
fix/switchConstructor
branch
from
5f0d9c6
to
7b930a8
Compare
This was referenced Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Intending to fix the LionSwitch throwing an error in non-lit environments:
roleto'switch'from theconstructorto theconnectedCallback.document.createElementinstead of relaying on lit in order to trigger the bug.