New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move all web pkgs into a single npm pkg @lion/ui #1802
Conversation
|
|
make 👉 - export { ScopedElementsMixin } from '@open-wc/scoped-elements';
- export { dedupeMixin } from '@open-wc/dedupe-mixin';and then adjust all imports to go to the external package directly - import { ScopedElementsMixin } from '@lion/components/core.js';
+ import { ScopedElementsMixin } from '@open-wc/scoped-elements';
- import { dedupeMixin } from '@lion/components/core.js';
+ import { dedupeMixin } from '@open-wc/dedupe-mixin'; |
3176d99
to
49b1921
Compare
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| "@lion/calendar": patch | |||
| '@lion/calendar': patch | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we remove all open changesets?
And have 1 changeset for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, but let's do this when we are actually closer to a release
What I did
@lion/uipackage containing all web components.@lion/ajaxandsingleton-managerwill remain separate packagesPS: this also requires changes to our TS setup which will follow next...