Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move all web pkgs into a single npm pkg @lion/ui #1802

Merged
merged 1 commit into from Oct 31, 2022

Conversation

daKmoR
Copy link
Contributor

@daKmoR daKmoR commented Oct 24, 2022

What I did

  1. With export maps we can get the same runtime cost by using multiple entrypoints as with separate packages - It however simplifies usage and maintenance a LOT.
  2. This introduces a single @lion/ui package containing all web components.
  3. @lion/ajax and singleton-manager will remain separate packages

PS: this also requires changes to our TS setup which will follow next...

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2022

⚠️ No Changeset found

Latest commit: 49b1921

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@daKmoR
Copy link
Contributor Author

daKmoR commented Oct 25, 2022

make core.js only export our own code... e.g. remove those 2 lines

👉 ing-web/exports/core.js

- export { ScopedElementsMixin } from '@open-wc/scoped-elements';
- export { dedupeMixin } from '@open-wc/dedupe-mixin';

and then adjust all imports to go to the external package directly

- import { ScopedElementsMixin } from '@lion/components/core.js';
+ import { ScopedElementsMixin } from '@open-wc/scoped-elements';

- import { dedupeMixin } from '@lion/components/core.js';
+ import { dedupeMixin } from '@open-wc/dedupe-mixin';

@daKmoR daKmoR changed the title feat: move all web components into a single npm pkg feat: move all web pkgs into a single npm pkg @lion/ui Oct 28, 2022
@@ -1,5 +1,5 @@
---
"@lion/calendar": patch
'@lion/calendar': patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove all open changesets?

And have 1 changeset for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but let's do this when we are actually closer to a release

@daKmoR daKmoR merged commit c9e060f into master Oct 31, 2022
@daKmoR daKmoR deleted the feat/componentsPkg branch October 31, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants