git subrepo pull/push fails if post-checkout script in a separate hooks folder writes to .git

[afcuttin]

If I change core.hooksPath to a folder (.githooks) different that .git/hooks/, and the post-checkout hook writes a file in .git, git subrepo pull fails as follows:

$ git subrepo pull aux
git-subrepo: Command failed: 'git worktree add .git/tmp/subrepo/aux subrepo/aux'.
Preparing .git/tmp/subrepo/aux (identifier aux)
HEAD is now at fcf0b6a verification of mechanical requirements
/path/to/project/.githooks/post-checkout: 15: /path/to/project/.githooks/post-checkout: cannot create .git/gitHeadInfo.gin: Directory nonexistent

This happens also with the default core.hooksPath setting

[admorgan]

That appears to be a limitation of your hook. It does not appear to be compatible with worktrees. I would suggest updating the hook to use git rev-parse --git-dir to determine where to place/access the gitHeadInfo.gin file.

[afcuttin]

the script is taken from here: https://ctan.org/tex-archive/macros/latex/contrib/gitinfo2

and is

#!/bin/sh
# Copyright 2015 Brent Longborough
# Part of gitinfo2 package Version 2
# Release 2.0.7 2015-11-22
# Please read gitinfo2.pdf for licencing and other details
# -----------------------------------------------------
# Post-{commit,checkout,merge} hook for the gitinfo2 package
#
# Get the first tag found in the history from the current HEAD
FIRSTTAG=$(git describe --tags --always --dirty='-*' 2>/dev/null)
# Get the first tag in history that looks like a Release
RELTAG=$(git describe --tags --long --always --dirty='-*' --match '[0-9]*.*' 2>/dev/null)
# Hoover up the metadata
git --no-pager log -1 --date=short --decorate=short \
    --pretty=format:"\usepackage[%
        shash={%h},
        lhash={%H},
        authname={%an},
        authemail={%ae},
        authsdate={%ad},
        authidate={%ai},
        authudate={%at},
        commname={%cn},
        commemail={%ce},
        commsdate={%cd},
        commidate={%ci},
        commudate={%ct},
        refnames={%d},
        firsttagdescribe={$FIRSTTAG},
        reltag={$RELTAG}
    ]{gitexinfo}" HEAD > .git/gitHeadInfo.gin

I understand that the last line is the tricky one..

[afcuttin]

Do you suggest something like

GINDIR=$(git rev-parse --git-dir 2>/dev/null)

and then in the last line

]{gitexinfo}" HEAD > $GINDIR/gitHeadInfo.gin

?

[admorgan]

Just a warning, but depending on how that info is used you might have a race condition assuming you are using a worktree outside of your main workspace. It might we wise to have some locking (of course then you have to worry about locking issues).