fix Safe and YAML issues #16

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
@dams
Collaborator

dams commented Apr 18, 2012

This PR fixes these issues :

https://rt.cpan.org/Public/Bug/Display.html?id=76664
https://rt.cpan.org/Public/Bug/Display.html?id=74487

This is just to demonstrate how to fix it. You might want to try to find a way to have it more golfed but still working...

@melo

This comment has been minimized.

Show comment
Hide comment
@melo

melo Apr 18, 2012

Contributor

@dams You are changing lib/Mo.pm but AFAIK lib/Mo.pm is a generated file via make -C src/.

Shouldn't this be done in src/Mo.pm?

Contributor

melo commented on lib/Mo.pm in 08a0f1a Apr 18, 2012

@dams You are changing lib/Mo.pm but AFAIK lib/Mo.pm is a generated file via make -C src/.

Shouldn't this be done in src/Mo.pm?

This comment has been minimized.

Show comment
Hide comment
@dams

dams Apr 19, 2012

Collaborator

@melo Aww yes, I had forgotten about that :) make test worked so I commited it, but yeah. I have added a new commit to the PR. Should be alright now

Collaborator

dams replied Apr 19, 2012

@melo Aww yes, I had forgotten about that :) make test worked so I commited it, but yeah. I have added a new commit to the PR. Should be alright now

@Leont

This comment has been minimized.

Show comment
Hide comment
@Leont

Leont Apr 19, 2012

Contributor

I've squashed and committed the patches

Contributor

Leont commented Apr 19, 2012

I've squashed and committed the patches

@Leont Leont closed this Apr 19, 2012

@dams

This comment has been minimized.

Show comment
Hide comment
@dams

dams Apr 23, 2012

Collaborator

@Leont thanks. But I think you meant "squashed and merged the commits" :)

Collaborator

dams commented Apr 23, 2012

@Leont thanks. But I think you meant "squashed and merged the commits" :)

@yanick yanick referenced this pull request in ingydotnet/jsony-pm Aug 15, 2014

Closed

Mo::Inline doesn't work if the sub ::"" is defined #2

@nfg nfg referenced this pull request Jul 5, 2016

Merged

Escape :: to avoid weird bug #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment