New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated dzil plugins #34

Merged
merged 2 commits into from Aug 29, 2016

Conversation

Projects
None yet
4 participants
@paultcochrane
Contributor

paultcochrane commented Aug 27, 2016

This PR fixes warnings from Dist::Zilla concerning deprecated plugins. It works around an issue with the upstream INGY Dist::Zilla bundle and replaces the NoTabsTests plugin with its recommended replacement.

If you have any questions or comments concerning this PR, please just let me know. If any changes are required, I can update the PR and resubmit.

paultcochrane added some commits Aug 27, 2016

Replace ReportVersions::Tiny with Test::ReportPrereqs
`Test::ReportPrereqs` is the recommended replacement for
`ReportVersions::Tiny`.  Unfortunately, the default INGY `Dist-Zilla` bundle
from CPAN is stuck at version 0.0.4 although 0.0.5 has been released, which
contains effectively this fix.  This change provides a workaround for the
issue until the upstream bundle can be fixed.
Replace NoTabsTests with Test::NoTabs
`NoTabsTests` is deprecated and may be removed in the future; its
replacement is `Test::NoTabs`.
@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Aug 27, 2016

Contributor

Apologies for the short initial comment: I accidentally hit return in the wrong context and submitted the pull request without having finished the comment.

Contributor

paultcochrane commented Aug 27, 2016

Apologies for the short initial comment: I accidentally hit return in the wrong context and submitted the pull request without having finished the comment.

@perlpunk

This comment has been minimized.

Show comment
Hide comment
@perlpunk

perlpunk Aug 27, 2016

Collaborator

@ingydotnet to me everything looks fine, should I merge it?

Collaborator

perlpunk commented Aug 27, 2016

@ingydotnet to me everything looks fine, should I merge it?

@dolmen

This comment has been minimized.

Show comment
Hide comment
@dolmen

dolmen Aug 29, 2016

Collaborator

As a committer on this project, a dzil expert and the ReportVersions::Tiny maintainer who deprecated the plugin, I say: 👍

But an even better way to fix the core issue would be to have Dist::Zilla::PluginBundle::INGY fixed (see ingydotnet/dist-zilla-pluginbundle-ingy-pm#2) and the dist.ini here to have a version requirement on that fixed version of the plugin. I can provide the patch for that once [@INGY] is fixed.

Collaborator

dolmen commented Aug 29, 2016

As a committer on this project, a dzil expert and the ReportVersions::Tiny maintainer who deprecated the plugin, I say: 👍

But an even better way to fix the core issue would be to have Dist::Zilla::PluginBundle::INGY fixed (see ingydotnet/dist-zilla-pluginbundle-ingy-pm#2) and the dist.ini here to have a version requirement on that fixed version of the plugin. I can provide the patch for that once [@INGY] is fixed.

@ingydotnet ingydotnet merged commit a750e81 into ingydotnet:master Aug 29, 2016

@ingydotnet

This comment has been minimized.

Show comment
Hide comment
@ingydotnet

ingydotnet Aug 29, 2016

Owner

Applied. Pushed. Thanks!

Owner

ingydotnet commented Aug 29, 2016

Applied. Pushed. Thanks!

@ingydotnet

This comment has been minimized.

Show comment
Hide comment
@ingydotnet

ingydotnet Aug 29, 2016

Owner

@dolmen, if you get around to all that, ping me on IRC. Cheers.

Owner

ingydotnet commented Aug 29, 2016

@dolmen, if you get around to all that, ping me on IRC. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment