New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone node before analyzing (fix #32) #55

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@vti
Contributor

vti commented Mar 6, 2017

It looks like SvPV_nomg adds the string representation for the number
and creates side effects.

perl -MDevel::Peek -MYAML::XS -e \
'$x = 123; print Devel::Peek::Dump($x); YAML::XS::Dump($x); print Devel::Peek::Dump($x)'

This breaks tied tests, but it looks like the test was invalid, since
generating bare values should be fine there.

clone node before analyzing (fix #32)
It looks like SvPV_nomg adds the string representation for the number
and creates side effects.

    perl -MDevel::Peek -MYAML::XS -e \
    '$x = 123; print Devel::Peek::Dump($x); YAML::XS::Dump($x); print Devel::Peek::Dump($x)'

This breaks tied tests, but it looks like the test was invalid, since
generating bare values should be fine there.
@perlpunk

This comment has been minimized.

Show comment
Hide comment
@perlpunk

perlpunk Aug 10, 2017

Collaborator

thanks! it looks good to me, although I don't fully understand the buggy behavior.
I pinged @ingydotnet

Collaborator

perlpunk commented Aug 10, 2017

thanks! it looks good to me, although I don't fully understand the buggy behavior.
I pinged @ingydotnet

@perlpunk

This comment has been minimized.

Show comment
Hide comment
@perlpunk

perlpunk Aug 10, 2017

Collaborator

I think I understand it now. I guess the SvTYPE comparison didn't work correctly before for tied data, that's why the tied.t test is correct now.

Collaborator

perlpunk commented Aug 10, 2017

I think I understand it now. I guess the SvTYPE comparison didn't work correctly before for tied data, that's why the tied.t test is correct now.

@ingydotnet

Looks good to me.

perlpunk added a commit that referenced this pull request Aug 13, 2017

@perlpunk

This comment has been minimized.

Show comment
Hide comment
@perlpunk

perlpunk Aug 13, 2017

Collaborator

thanks again, merged and released as 0.65_001!
I also added a test for this.

Collaborator

perlpunk commented Aug 13, 2017

thanks again, merged and released as 0.65_001!
I also added a test for this.

@perlpunk

This comment has been minimized.

Show comment
Hide comment
@perlpunk

perlpunk Aug 17, 2017

Collaborator

Released 0.66

Collaborator

perlpunk commented Aug 17, 2017

Released 0.66

@perlpunk perlpunk closed this Aug 17, 2017

gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Apr 3, 2018

dev-perl/YAML-LibYAML: Bump to version 0.690.0
Upstream:
- (Security) Add $LoadBlessed option[1] to run on/off loading objects
- Fix regex roundtrip [2]
- Fix loading of many regex classes [3]
- Support tags !!str, !!map and !!seq [4]
- Support JSON::PP::Boolean via $YAML::XS::Boolean [5]
- Fix Dump modifying inspected values [6]

[1]
Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861958
Bug: ingydotnet/yaml-libyaml-pm#45
Bug: ingydotnet/yaml-libyaml-pm#73
Bug: ingydotnet/yaml-libyaml-pm#74
[2]
Bug: ingydotnet/yaml-libyaml-pm#69
Bug: ingydotnet/yaml-libyaml-pm#70
[3]
Bug: ingydotnet/yaml-libyaml-pm#64
Bug: ingydotnet/yaml-libyaml-pm#71
[4]
Bug: ingydotnet/yaml-libyaml-pm#67
[5]
Bug: ingydotnet/yaml-libyaml-pm#66
[6]
Bug: ingydotnet/yaml-libyaml-pm#32
Bug: ingydotnet/yaml-libyaml-pm#55
Package-Manager: Portage-2.3.24, Repoman-2.3.6

madmartin added a commit to madmartin/gentoo that referenced this pull request Apr 4, 2018

dev-perl/YAML-LibYAML: Bump to version 0.690.0
Upstream:
- (Security) Add $LoadBlessed option[1] to run on/off loading objects
- Fix regex roundtrip [2]
- Fix loading of many regex classes [3]
- Support tags !!str, !!map and !!seq [4]
- Support JSON::PP::Boolean via $YAML::XS::Boolean [5]
- Fix Dump modifying inspected values [6]

[1]
Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861958
Bug: ingydotnet/yaml-libyaml-pm#45
Bug: ingydotnet/yaml-libyaml-pm#73
Bug: ingydotnet/yaml-libyaml-pm#74
[2]
Bug: ingydotnet/yaml-libyaml-pm#69
Bug: ingydotnet/yaml-libyaml-pm#70
[3]
Bug: ingydotnet/yaml-libyaml-pm#64
Bug: ingydotnet/yaml-libyaml-pm#71
[4]
Bug: ingydotnet/yaml-libyaml-pm#67
[5]
Bug: ingydotnet/yaml-libyaml-pm#66
[6]
Bug: ingydotnet/yaml-libyaml-pm#32
Bug: ingydotnet/yaml-libyaml-pm#55
Package-Manager: Portage-2.3.24, Repoman-2.3.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment