New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LoadCode #180

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@mohawk2
Contributor

mohawk2 commented Oct 22, 2017

With an inline value, it was both getting _parse_inline AND (if $explicit) also _parse_explicit. A guard variable now prevents that. All tests old and new still pass.

(I also removed an unused variable in _parse_node: $escape)

@mohawk2

This comment has been minimized.

Show comment
Hide comment
@mohawk2

mohawk2 Oct 22, 2017

Contributor

This also fixes #59 .

Contributor

mohawk2 commented Oct 22, 2017

This also fixes #59 .

@ingydotnet

This comment has been minimized.

Show comment
Hide comment
@ingydotnet

ingydotnet Oct 23, 2017

Owner

+1 @perlpunk please apply.

We'll need to update YAML::Old too until we do the new release thing.

Owner

ingydotnet commented Oct 23, 2017

+1 @perlpunk please apply.

We'll need to update YAML::Old too until we do the new release thing.

@perlpunk

This comment has been minimized.

Show comment
Hide comment
@perlpunk

perlpunk Oct 25, 2017

Collaborator

Thanks, applied!
I'm planning a dev release

Collaborator

perlpunk commented Oct 25, 2017

Thanks, applied!
I'm planning a dev release

@perlpunk

This comment has been minimized.

Show comment
Hide comment
@perlpunk

perlpunk Oct 25, 2017

Collaborator

An issue was found by travis with perl <= 5.14, will look into it, there are already tests that take different perl/B::Deparse versions into account.

Collaborator

perlpunk commented Oct 25, 2017

An issue was found by travis with perl <= 5.14, will look into it, there are already tests that take different perl/B::Deparse versions into account.

@mohawk2 mohawk2 closed this Oct 25, 2017

@mohawk2 mohawk2 deleted the mohawk2:fix-loadcode branch Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment