New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trailing comments where this has been an error before #190

Merged
merged 1 commit into from Apr 27, 2018

Conversation

Projects
None yet
1 participant
@perlpunk
Collaborator

perlpunk commented Apr 19, 2018

In these cases we can just support it without making it optional

This should wait for #188 being merged, as comments after quoted strings still have to be added

@perlpunk perlpunk force-pushed the trailing-comments-noncontent branch from f94d04c to 9595c5c Apr 19, 2018

@perlpunk perlpunk changed the title from Support trailing commas where this has been an error before to Support trailing comments where this has been an error before Apr 19, 2018

@perlpunk perlpunk changed the title from Support trailing comments where this has been an error before to WIP: Support trailing comments where this has been an error before Apr 21, 2018

@perlpunk perlpunk force-pushed the trailing-comments-noncontent branch from 9595c5c to 04988d6 Apr 27, 2018

@perlpunk perlpunk force-pushed the trailing-comments-noncontent branch from 04988d6 to 8d207bc Apr 27, 2018

@perlpunk

This comment has been minimized.

Collaborator

perlpunk commented Apr 27, 2018

See test/trailing-comments-non-content.t for the cases that allow trailing comments now.

@perlpunk perlpunk changed the title from WIP: Support trailing comments where this has been an error before to Support trailing comments where this has been an error before Apr 27, 2018

@perlpunk perlpunk merged commit 8d207bc into master Apr 27, 2018

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@perlpunk perlpunk deleted the trailing-comments-noncontent branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment