New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support ignoring trailing comments after content #191

Merged
merged 1 commit into from Apr 29, 2018

Conversation

Projects
None yet
1 participant
@perlpunk
Collaborator

perlpunk commented Apr 19, 2018

This needs documentation.

Also there should be a test which tests previous behaviour. Currently there is no test that contains trailing comments that become part of the content, that's why all existing tests actually suceed even without setting $YAML::TrailingComments.

@perlpunk perlpunk force-pushed the trailing-comments-content branch from dfee406 to 6940c12 Apr 19, 2018

@perlpunk perlpunk force-pushed the trailing-comments-content branch from 2d877df to 894fb84 Apr 27, 2018

@perlpunk perlpunk force-pushed the trailing-comments-content branch from 894fb84 to a223174 Apr 29, 2018

@perlpunk

This comment has been minimized.

Collaborator

perlpunk commented Apr 29, 2018

@ingydotnet gave his go for adding trailing comments by default, without an option. Changed my PR and rebased

@perlpunk perlpunk merged commit a223174 into master Apr 29, 2018

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@perlpunk perlpunk deleted the trailing-comments-content branch Apr 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment