Add missing v prefix to ppx_let lower bound #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seliopou Hmm so using ppx_let >= v0.14.0 eventually requires OCaml >= 4.07.0 which breaks the 4.06 build. Do you want to drop 4.06 from the Travis build and maybe add 4.11 to round things out? |
ppx_let >= 0.14.0 requires OCaml 4.07, so it can't be used for tests.
seliopou
reviewed
Feb 7, 2021
|
Thanks! I'll fix the OCaml version constraint separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this might fix the build issue, but will wait for Travis to finish running.