Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor & improve serializer #383

Merged
merged 11 commits into from
Feb 15, 2022
Merged

Conversation

fb55
Copy link
Collaborator

@fb55 fb55 commented Jan 18, 2022

Simplifies the serializer by removing the wrapping class, fixes mixed content (#333), adds the scripting flag (#332), and adds a serializeOuter method (#230, #378). Also fixes passing a <template> element to serialize resulting in an empty string.

The parse5-serializer-stream module should be deprecated after these changes.

@fb55 fb55 marked this pull request as ready for review February 7, 2022 14:34
@fb55 fb55 linked an issue Feb 7, 2022 that may be closed by this pull request
@fb55 fb55 merged commit b3338ff into inikulin:master Feb 15, 2022
@fb55 fb55 deleted the refactor/serializer branch February 15, 2022 13:01
fb55 added a commit to parse5/parse5-fork that referenced this pull request Mar 2, 2022
Co-authored-by: Joel Denning <5524384+joeldenning@users.noreply.github.com>
@kongxiangyan
Copy link

serializeOuter is really a convenient feature for just serializing a piece of html works. I wonder know when it will be released in a official version. Or am I missed some approaches that can import the latest commit to my project❓

@fb55
Copy link
Collaborator Author

fb55 commented Apr 1, 2022

I am trying to make a release happen – should only be another week or two.

@wooorm
Copy link
Collaborator

wooorm commented Apr 1, 2022

@fb55 Maybe good to create a (pinned) issue tracking it and what needs to be done?

@fb55
Copy link
Collaborator Author

fb55 commented Apr 1, 2022

@wooorm I've done a push to tackle the remaining items I want to see, and have opened PRs for them. Once these are concluded, I am ready to get a release out.

jmbpwtw pushed a commit to jmbpwtw/parse5 that referenced this pull request Feb 16, 2023
Co-authored-by: Joel Denning <5524384+joeldenning@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants