From d85f4faa05206e7e5e3cdcf8d06c77422b728129 Mon Sep 17 00:00:00 2001 From: Anna Carroll Date: Tue, 17 Jun 2025 13:35:48 +0200 Subject: [PATCH 1/7] log request before & after gas normalization --- crates/rpc/src/eth/endpoints.rs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/crates/rpc/src/eth/endpoints.rs b/crates/rpc/src/eth/endpoints.rs index 1bda6901..5978d2a9 100644 --- a/crates/rpc/src/eth/endpoints.rs +++ b/crates/rpc/src/eth/endpoints.rs @@ -527,10 +527,6 @@ where { let id = block.unwrap_or(BlockId::pending()); - // Stateless gas normalization. - let max_gas = ctx.signet().config().rpc_gas_cap; - normalize_gas_stateless(&mut request, max_gas); - // this span is verbose yo. let span = trace_span!( "estimate_gas", @@ -541,6 +537,12 @@ where block_cfg = tracing::field::Empty, ); + // Stateless gas normalization. + let max_gas = ctx.signet().config().rpc_gas_cap; + normalize_gas_stateless(&mut request, max_gas); + + tracing::span::Span::current().record("normalized_gas", format!("{:?}", request.gas)); + let task = async move { // Get the block cfg from backend, erroring if it fails let block_cfg = match ctx.signet().block_cfg(id).await { From 0873d807aa5998f72b7fe8593dbcd16d94371ee2 Mon Sep 17 00:00:00 2001 From: Anna Carroll Date: Tue, 17 Jun 2025 15:14:22 +0200 Subject: [PATCH 2/7] add estimation result --- crates/rpc/src/eth/endpoints.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crates/rpc/src/eth/endpoints.rs b/crates/rpc/src/eth/endpoints.rs index 5978d2a9..e5ad459b 100644 --- a/crates/rpc/src/eth/endpoints.rs +++ b/crates/rpc/src/eth/endpoints.rs @@ -570,6 +570,8 @@ where let (estimate, _) = response_tri!(trevm.estimate_gas().map_err(EvmErrored::into_error)); + tracing::span::Span::current().record("estimate", format!("{:?}", &estimate)); + match estimate { trevm::EstimationResult::Success { estimation, .. } => { ResponsePayload::Success(U64::from(estimation)) From 36150491e073770e34561a04980659ba31d21011 Mon Sep 17 00:00:00 2001 From: evalir Date: Tue, 17 Jun 2025 15:35:42 +0200 Subject: [PATCH 3/7] chore: lock down dfeps --- Cargo.toml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index d4c44e0e..af9bd891 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -46,10 +46,10 @@ signet-tx-cache = { path = "crates/tx-cache" } signet-zenith = { path = "crates/zenith" } # ajj -ajj = { version = "0.3.1" } +ajj = { version = "0.3.4" } # trevm -trevm = { version = "0.23.4", features = ["full_env_cfg"] } +trevm = { version = "=0.23.4", features = ["full_env_cfg"] } # Alloy periphery crates alloy = { version = "=1.0.5", features = [ @@ -80,7 +80,7 @@ reth-transaction-pool = { git = "https://github.com/paradigmxyz/reth", tag = "v1 reth-trie-db = { git = "https://github.com/paradigmxyz/reth", tag = "v1.4.3" } # Foundry periphery -foundry-blob-explorers = "0.10" +foundry-blob-explorers = "=0.10" # Async tokio = { version = "1.43.0", features = ["macros"] } @@ -114,4 +114,4 @@ hex = { package = "const-hex", version = "1.10", default-features = false, featu uuid = "1.16.0" # Test Utils -alloy-rlp = "0.3.11" +alloy-rlp = "=0.3.11" From 255707f99d5598f6fa92fc8c7d447145659336a9 Mon Sep 17 00:00:00 2001 From: evalir Date: Tue, 17 Jun 2025 16:01:43 +0200 Subject: [PATCH 4/7] chore: force 1.0.5 --- Cargo.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/Cargo.toml b/Cargo.toml index af9bd891..d868dad3 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -58,6 +58,7 @@ alloy = { version = "=1.0.5", features = [ "genesis", "arbitrary", ] } +alloy-rpc-types-mev = { version = "=1.0.5" } alloy-contract = { version = "=1.0.5", features = ["pubsub"] } # Reth From 948adde83b848ce582f39603951c916fafa1c475 Mon Sep 17 00:00:00 2001 From: evalir Date: Tue, 17 Jun 2025 16:16:11 +0200 Subject: [PATCH 5/7] chore: just update the test --- crates/bundle/src/send/bundle.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/bundle/src/send/bundle.rs b/crates/bundle/src/send/bundle.rs index 7b9e5419..a6be0ef1 100644 --- a/crates/bundle/src/send/bundle.rs +++ b/crates/bundle/src/send/bundle.rs @@ -148,6 +148,7 @@ mod test { max_timestamp: Some(3), reverting_tx_hashes: vec![B256::repeat_byte(4), B256::repeat_byte(5)], replacement_uuid: Some("uuid".to_owned()), + ..Default::default() }, host_fills: Some(SignedFill { permit: Permit2Batch { From c95772cae1802382f7fdb06d2bf09f039624ff70 Mon Sep 17 00:00:00 2001 From: evalir Date: Tue, 17 Jun 2025 16:22:18 +0200 Subject: [PATCH 6/7] chore: more fixes --- crates/rpc/examples/filler.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/rpc/examples/filler.rs b/crates/rpc/examples/filler.rs index ff36333e..77d49460 100644 --- a/crates/rpc/examples/filler.rs +++ b/crates/rpc/examples/filler.rs @@ -135,6 +135,7 @@ where min_timestamp: None, // sufficiently covered by pinning to next block number max_timestamp: None, // sufficiently covered by pinning to next block number replacement_uuid: None, // optional if implementing strategies that replace or cancel bundles + ..Default::default() // all other options are not used. }, }; From 96d0edb7966f5fb02e8a593ae8b096886d65fca6 Mon Sep 17 00:00:00 2001 From: evalir Date: Tue, 17 Jun 2025 16:23:43 +0200 Subject: [PATCH 7/7] chore: more fixes --- crates/rpc/examples/filler.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/rpc/examples/filler.rs b/crates/rpc/examples/filler.rs index 77d49460..05b4986f 100644 --- a/crates/rpc/examples/filler.rs +++ b/crates/rpc/examples/filler.rs @@ -135,7 +135,7 @@ where min_timestamp: None, // sufficiently covered by pinning to next block number max_timestamp: None, // sufficiently covered by pinning to next block number replacement_uuid: None, // optional if implementing strategies that replace or cancel bundles - ..Default::default() // all other options are not used. + ..Default::default() // all other options are not used. }, };