-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when running git-sim stash push/pop #1
Comments
Ah yes, well the reason is that so far I have only implemented the bare bones |
Hi @initialcommit-io Let me know your thoughts on it. Also, do you know how to apply the |
@abhijitnathwani Thanks a lot for this and great work on it so far. Good points about only using subcommands that make sense in a 3-column layout for now. Also I like your idea for the strikethough for commands that delete the stashed entry. I just did some testing in Manim and was able to get the strikethrough to work like this:
The text objects are currently created in the
I'll leave that decision up to you, if you think one option works better than the other. |
@abhijitnathwani FYI I worked with @paketb0te to do some pretty significant refactoring to switch from argparse to Typer. Just wanted to give you a heads up since I know you already started on this. |
@initialcommit-io yeah, I saw the PR getting merged into the main branch. I was following the discussion on the Typer. I thought I'd finish this PR before that :D |
@abhijitnathwani Thanks for this and for accommodating the big changes... |
Hi @initialcommit-io , Proposed approach:
|
@abhijitnathwani I am not sure if you saw it in the discussion of #43, HERE are the docs for nested subcommands in Typer :) |
@abhijitnathwani Sure I think that sounds good. One thing to note, I added a Feel free to submit the PR when ready and I'll take a look. |
Hi, when trying to simulate the pop operation, i am getting the following error.
Although, not using the
push
command and giving the file name directly seems to workSame happens with pop command.
The text was updated successfully, but these errors were encountered: