Skip to content

More observable Wasm#75

Merged
expede merged 3 commits intomainfrom
observe
Mar 6, 2026
Merged

More observable Wasm#75
expede merged 3 commits intomainfrom
observe

Conversation

@expede
Copy link
Member

@expede expede commented Mar 6, 2026

Don't strip symbols & improve a few expect messages

@expede expede marked this pull request as ready for review March 6, 2026 21:16
@expede expede requested review from alexjg and jtfmumm as code owners March 6, 2026 21:16
Copilot AI review requested due to automatic review settings March 6, 2026 21:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to improve production observability for the Wasm builds by preserving symbol names (for readable stack traces) and making JS boundary failures easier to diagnose via safer casts and clearer expect messages.

Changes:

  • Preserve Wasm function names in release builds by adjusting per-package strip settings for Wasm crates.
  • Improve runtime diagnostics by replacing unchecked_into with fallible dyn_into at several JS/Wasm boundaries and upgrading expect messages.
  • Move console_error_panic_hook installation to module instantiation via a wasm-bindgen start function and enable the feature by default for subduction_wasm.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
subduction_wasm/src/subduction.rs Switch hash metric override casting from unchecked to fallible with clearer panic text.
subduction_wasm/src/signer/webcrypto.rs Improve expect messages around IDB upgrade flow and key parsing; clarify WebCrypto sign failure text.
subduction_wasm/src/signer.rs Make JS signer return-type handling fail loudly with explicit dyn_into diagnostics.
subduction_wasm/src/lib.rs Add #[wasm_bindgen(start)] to install the panic hook at module instantiation time.
subduction_wasm/src/connection.rs Replace unchecked JS casts with dyn_into and add an error variant for unexpected JS types.
subduction_wasm/Cargo.toml Enable console_error_panic_hook by default.
sedimentree_wasm/src/storage.rs Make digest parsing fallible and convert several unchecked casts into typed errors.
Cargo.toml Override release profile stripping for Wasm crates to keep names while stripping DWARF debuginfo.
flake.lock Update pinned Nix inputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@expede expede merged commit e8a6a44 into main Mar 6, 2026
24 checks passed
@expede expede deleted the observe branch March 6, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants