Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Params doesn't properly handle default black fill #362

Closed
ARKopp opened this Issue Dec 8, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@ARKopp
Copy link

ARKopp commented Dec 8, 2018

I am getting an error when clicking on Parameter only when the object is black. When I fill it with another color I get an error.
screenshot 2018-12-08 19 56 31

@lexelby

This comment has been minimized.

Copy link
Member

lexelby commented Dec 8, 2018

That looks like a bug to me. Would you mind posting that SVG here so that I can take a look on my end?

@ARKopp

This comment has been minimized.

Copy link
Author

ARKopp commented Dec 8, 2018

buga.svg.zip
Here you go ....

@lexelby

This comment has been minimized.

Copy link
Member

lexelby commented Dec 9, 2018

Thanks! I get what's happening now. SVG paths default to black fill if they don't have a fill or stroke set. Inkscape always sets black fill explicitly as fill:#000000 but other SVG editors don't. I'm guessing maybe you made this SVG in another application?

The bug is that Ink/Stitch's Params extension doesn't treat a lack of fill or stroke as equivalent to a black fill. I'll get that fixed soon.

In the meantime, if you want a black fill, here's a workaround:

  1. select the object
  2. open Inkscape's "Fill and Stroke" dialog
  3. enable fill for the object
  4. set the fill to black

Sorry for the inconvenience, and thanks for reporting this bug!

@lexelby lexelby changed the title error message when object black Params doesn't properly handle default black fill Dec 9, 2018

@ARKopp

This comment has been minimized.

Copy link
Author

ARKopp commented Dec 9, 2018

thanks lex but I used Inkscape to make this letter. Maybe it happens with certain fonts?

@lexelby

This comment has been minimized.

Copy link
Member

lexelby commented Dec 12, 2018

Oh interesting. I wasn't able to create such a path, so I just assumed. In any case, it's a bug and needs fixing :)

@lexelby lexelby added the bug label Dec 12, 2018

@lexelby lexelby referenced this issue Dec 13, 2018

Merged

bug fixes #364

@lexelby lexelby closed this in #364 Feb 16, 2019

lexelby added a commit that referenced this issue Feb 16, 2019

v1.22.0: tons of bug fixes!
Bug fixes:
  * properly handle black fill (#362)
  * don't create paths with empty "d" attribute when importing DST, PES, etc (#363)
  * properly encode trims in JEF files (#377)
  * significantly improve error messages for crashes in auto-fill
  * informative error message for auto-fill of extremely tiny shapes
  * fix file corruption in "Save As" JEF, DST, etc (all formats) (#387)
    * Ink/Stitch was erroneously adding a carriage return at the end of the file
  * fix print metadata (#372)
  * fix adding presets in Params (#381)
  * fix crash if fill start and end points are very close
  * don't crash on a design with no stitches
  * support manual stitch paths with a single stitch

New feature:
  * option to skip the last stitch in each row of fill stitch
    * usually that stitch is unnecessary and will be very close to the stitch at the start of the next row
    * this can reduce stitch count for "free" in most cases
@ARKopp

This comment has been minimized.

Copy link
Author

ARKopp commented Mar 10, 2019

thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.