Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embroidery file import can produce paths with empty "d" attribute #363

Closed
jameskolme opened this Issue Dec 11, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@jameskolme
Copy link

jameskolme commented Dec 11, 2018

Getting this lately, importing .dst and export/params/simulate gives this error.
path6248: error: Object path6248 has an empty 'd' attribute. Please delete this object from your document.

Might be something to do with original program?

@lexelby

This comment has been minimized.

Copy link
Member

lexelby commented Dec 12, 2018

Ah, thanks! It's a bug: the embroidery file importer shouldn't create empty paths.

@lexelby lexelby changed the title Object path has an empty 'd' embroidery file import can produce paths with empty "d" attribute Dec 12, 2018

@lexelby

This comment has been minimized.

Copy link
Member

lexelby commented Dec 12, 2018

Any chance you could post an example DST that causes this problem?

@jameskolme

This comment has been minimized.

Copy link
Author

jameskolme commented Dec 12, 2018

I can make one step better, here is .pes and .dst files, both cause same error.

kala.zip
LR.zip

@lexelby

This comment has been minimized.

Copy link
Member

lexelby commented Dec 14, 2018

Perfect, thank you! I see the error with those files and I've confirmed that #364 fixes it.

@lexelby lexelby closed this in #364 Feb 16, 2019

lexelby added a commit that referenced this issue Feb 16, 2019

v1.22.0: tons of bug fixes!
Bug fixes:
  * properly handle black fill (#362)
  * don't create paths with empty "d" attribute when importing DST, PES, etc (#363)
  * properly encode trims in JEF files (#377)
  * significantly improve error messages for crashes in auto-fill
  * informative error message for auto-fill of extremely tiny shapes
  * fix file corruption in "Save As" JEF, DST, etc (all formats) (#387)
    * Ink/Stitch was erroneously adding a carriage return at the end of the file
  * fix print metadata (#372)
  * fix adding presets in Params (#381)
  * fix crash if fill start and end points are very close
  * don't crash on a design with no stitches
  * support manual stitch paths with a single stitch

New feature:
  * option to skip the last stitch in each row of fill stitch
    * usually that stitch is unnecessary and will be very close to the stitch at the start of the next row
    * this can reduce stitch count for "free" in most cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.