Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill underlay inset #108

Merged
merged 3 commits into from Mar 2, 2018
Merged

Fill underlay inset #108

merged 3 commits into from Mar 2, 2018

Conversation

@lexelby
Copy link
Member

@lexelby lexelby commented Feb 28, 2018

This PR adds an inset option for fill underlay. The actual code that implements the insetting is very simple. However, to make that possible, I had to refactor a lot of the code. That's a good thing, because it means that future changes will be a lot easier and the codebase will be more understandable.

For a fun time, try a negative autofill underlay inset value ;)

cc @wwderw
fixes #39

@X3msnake
Copy link
Member

@X3msnake X3msnake commented Feb 28, 2018

wwderw
wwderw approved these changes Feb 28, 2018
Copy link
Contributor

@wwderw wwderw left a comment

Everything appears good on my end.

There is actually a real world use for that negative inset and that is to "tame the pile". On items such as towels, a loose fill stitch helps "knock" everything down in order to help with crisper top stitches.

Some people refer to these stitches as "knockdown" stitches. I've always done them separately, but that's because I hadn't really noticed the ability to do negative insets (or "margins" in their case) in other software.

@lexelby
Copy link
Member Author

@lexelby lexelby commented Feb 28, 2018

Oooh, good point! I love that idea. That suggests the need for double underlay for fill, that is, underlay in one direction and then another direction 90 degrees rotated. Want to add a feature request for that?

@X3msnake
Copy link
Member

@X3msnake X3msnake commented Feb 28, 2018

@lexelby
Copy link
Member Author

@lexelby lexelby commented Feb 28, 2018

I did.

@lexelby
Copy link
Member Author

@lexelby lexelby commented Mar 1, 2018

BONUS CONTENT!

This version unlocks a hidden feature I used for gradient blending on this patch. If you use the XML editor to add the hidden setting embroider_end_row_spacing_mm, you'll get an effect like the one described in #78, Exponent Modifier for Fill and Satin (just the fill part).

It isn't quite ready for prime-time, so I haven't added it to the UI yet. Notably, certain shapes with complicated holes seem to cause the autofill algorithm to run forever and never finish, and you have to kill the process manually. But for most shapes, it seems to do the job. Combine two such fills going in opposing directions and you'd get a gradient fill.

@lexelby lexelby merged commit 2ddc013 into master Mar 2, 2018
2 checks passed
@lexelby lexelby deleted the fill-underlay-inset branch Mar 2, 2018
@X3msnake
Copy link
Member

@X3msnake X3msnake commented Mar 2, 2018

@lexelby Awsome You are the Master :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants