Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix print metadata #372

Merged
merged 2 commits into from Jan 1, 2019

Conversation

Projects
None yet
3 participants
@kaalleen
Copy link
Collaborator

kaalleen commented Dec 31, 2018

This should fix #368

The problem were the keywords in the documents metadata of the Inkscape file. This would create an li-tag to the svg output. Browsers would misinterpreted it as and HTML list item. They internally close the svg and display the keywords as a list right after.

The solution (for now?) is to simply remove every li-tag from the svg within the print output, while leaving the keywords alive. This might not be the best way to prevent this issue from happening. But it was the easiest way for me at this point.

@wwderw does it solve your issue?

kaalleen added some commits Dec 31, 2018

@lexelby

This comment has been minimized.

Copy link
Member

lexelby commented Dec 31, 2018

Awesome, thanks for figuring this out!

@wwderw

wwderw approved these changes Dec 31, 2018

Copy link
Member

wwderw left a comment

Yep, that seemed to work for me.

@kaalleen kaalleen merged commit 85e12f4 into master Jan 1, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kaalleen kaalleen deleted the fix-print-metadata branch Jan 1, 2019

lexelby added a commit that referenced this pull request Feb 16, 2019

lexelby added a commit that referenced this pull request Feb 16, 2019

v1.22.0: tons of bug fixes!
Bug fixes:
  * properly handle black fill (#362)
  * don't create paths with empty "d" attribute when importing DST, PES, etc (#363)
  * properly encode trims in JEF files (#377)
  * significantly improve error messages for crashes in auto-fill
  * informative error message for auto-fill of extremely tiny shapes
  * fix file corruption in "Save As" JEF, DST, etc (all formats) (#387)
    * Ink/Stitch was erroneously adding a carriage return at the end of the file
  * fix print metadata (#372)
  * fix adding presets in Params (#381)
  * fix crash if fill start and end points are very close
  * don't crash on a design with no stitches
  * support manual stitch paths with a single stitch

New feature:
  * option to skip the last stitch in each row of fill stitch
    * usually that stitch is unnecessary and will be very close to the stitch at the start of the next row
    * this can reduce stitch count for "free" in most cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.