Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra self param from store_preset call. #381

Merged
merged 2 commits into from Jan 16, 2019

Conversation

Projects
None yet
2 participants
@redhat421
Copy link
Collaborator

redhat421 commented Jan 16, 2019

It looks like this prevents adding new params presets.

redhat421 added some commits Jan 16, 2019

Remove extra self param from store_preset call.
It looks like an extra "self" parameter was added to the store_preset call in the add_preset function.

This prevents add_preset from working.
Merge pull request #1 from redhat421/redhat421-patch-1
Remove extra self param from store_preset call.
@redhat421

This comment has been minimized.

Copy link
Collaborator Author

redhat421 commented Jan 16, 2019

Note that this is my first pull request, sorry if It's a horrible mess. :-)

Thanks for making InkStitch! It's awesome.

@lexelby

This comment has been minimized.

Copy link
Member

lexelby commented Jan 16, 2019

What the... how did I never notice that?! Thank you so much!

Welcome to the project! We're more than happy to discuss pull requests and work together on them, so please don't hesitate at all to create one. I'm glad you like Ink/Stitch!

@lexelby

This comment has been minimized.

Copy link
Member

lexelby commented Jan 16, 2019

I've granted you write access to the repository. That allows you to push branches, which will automatically trigger a Travis build. Once a build completes, you'll see a pre-release show up here: https://github.com/inkstitch/inkstitch/releases

That allows you to test out your changes and see if they work. This one's so simple I'm just going to merge it. :)

@lexelby lexelby merged commit ea84cea into inkstitch:master Jan 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redhat421

This comment has been minimized.

Copy link
Collaborator Author

redhat421 commented Jan 16, 2019

Awesome!

Thanks again for the quick review and warm welcome. :-)

lexelby added a commit that referenced this pull request Feb 16, 2019

Remove extra self param from store_preset call. (#381)
It looks like an extra "self" parameter was added to the store_preset call in the add_preset function.

This prevents add_preset from working.

@lexelby lexelby referenced this pull request Feb 16, 2019

Merged

bug fixes #364

lexelby added a commit that referenced this pull request Feb 16, 2019

v1.22.0: tons of bug fixes!
Bug fixes:
  * properly handle black fill (#362)
  * don't create paths with empty "d" attribute when importing DST, PES, etc (#363)
  * properly encode trims in JEF files (#377)
  * significantly improve error messages for crashes in auto-fill
  * informative error message for auto-fill of extremely tiny shapes
  * fix file corruption in "Save As" JEF, DST, etc (all formats) (#387)
    * Ink/Stitch was erroneously adding a carriage return at the end of the file
  * fix print metadata (#372)
  * fix adding presets in Params (#381)
  * fix crash if fill start and end points are very close
  * don't crash on a design with no stitches
  * support manual stitch paths with a single stitch

New feature:
  * option to skip the last stitch in each row of fill stitch
    * usually that stitch is unnecessary and will be very close to the stitch at the start of the next row
    * this can reduce stitch count for "free" in most cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.