Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid jumps when not underpathing autofill #606

Merged
merged 4 commits into from Mar 19, 2020
Merged

avoid jumps when not underpathing autofill #606

merged 4 commits into from Mar 19, 2020

Conversation

lexelby
Copy link
Member

@lexelby lexelby commented Jan 31, 2020

This bug was introduced with the underpathing feature for auto-fill. When you disable underpathing, Ink/Stitch will jump from your starting point directly to the first line of stitching. This is most obvious when you have a wide underlay on a square. It can sometimes jump a long distance from the underlay to the first stitch of the top fill.

This fixes that, adding extra points along the border that Ink/Stitch can use to travel when underpathing is disabled.

Also fixes at least some cases of #563, which were a different manifestation of the same kind of problem.

@kaalleen
Copy link
Collaborator

@kaalleen kaalleen commented Feb 4, 2020

This one looks also good to me, no errors found so far.
Instead I discovered a "before error", which is already fixed by this pull request.
Well done!

fill-fix

@lexelby
Copy link
Member Author

@lexelby lexelby commented Feb 15, 2020

Yay! I didn't even think of that, but I see why this branch fixes it.

I found a bug and just pushed a fix. Kind of hilarious, it would do running stitch across empty space to get to a fill shape, fill it, then do running stitch back. Whoopsies.

@lexelby lexelby merged commit 88a38cc into master Mar 19, 2020
4 checks passed
@lexelby lexelby deleted the lexelby/fill-fix branch Mar 19, 2020
kaalleen added a commit that referenced this issue May 16, 2020
## New Features

- New Simulator (#531)
- Import Threadlist (#666)
- Export Threadlist in ZIP file (#664)
- Option to include SVG in ZIP file (#648)
- Break Apart and Retain Holes (#653)
- G-Code: option to alternate z-value (#659)
- New Stitch Plan Extension (#640)
- Optionally enable/disable ties (lock down stitches) (#619)
- Multiple Fill Underlays
- Additional Fonts (#683):
    * Geneva
    * DejaVu

## Improvements

- Better Algorithm for Satin Columns (#607)
- Better Algorithm for Fill Stitches (#606)
- Convert to Satin with Loops (#608)
- Adding '@ #' to all fonts (#680)

## Bug Fixes

- Fix Issue with Troubleshoot Pointer Position (#696)
- Inherit Styles (#673)
- Fix Color Palette Issues (#660)
- Preserve Aspect Ratio (#646)
- and more

## Under the Hood

- Namespaced Attributes (#657)
- Remove stub.py (#629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants