avoid jumps when not underpathing autofill #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one looks also good to me, no errors found so far.
|
|
Yay! I didn't even think of that, but I see why this branch fixes it. I found a bug and just pushed a fix. Kind of hilarious, it would do running stitch across empty space to get to a fill shape, fill it, then do running stitch back. Whoopsies. |
kaalleen
added a commit
that referenced
this issue
May 16, 2020
## New Features - New Simulator (#531) - Import Threadlist (#666) - Export Threadlist in ZIP file (#664) - Option to include SVG in ZIP file (#648) - Break Apart and Retain Holes (#653) - G-Code: option to alternate z-value (#659) - New Stitch Plan Extension (#640) - Optionally enable/disable ties (lock down stitches) (#619) - Multiple Fill Underlays - Additional Fonts (#683): * Geneva * DejaVu ## Improvements - Better Algorithm for Satin Columns (#607) - Better Algorithm for Fill Stitches (#606) - Convert to Satin with Loops (#608) - Adding '@ #' to all fonts (#680) ## Bug Fixes - Fix Issue with Troubleshoot Pointer Position (#696) - Inherit Styles (#673) - Fix Color Palette Issues (#660) - Preserve Aspect Ratio (#646) - and more ## Under the Hood - Namespaced Attributes (#657) - Remove stub.py (#629)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This bug was introduced with the underpathing feature for auto-fill. When you disable underpathing, Ink/Stitch will jump from your starting point directly to the first line of stitching. This is most obvious when you have a wide underlay on a square. It can sometimes jump a long distance from the underlay to the first stitch of the top fill.
This fixes that, adding extra points along the border that Ink/Stitch can use to travel when underpathing is disabled.
Also fixes at least some cases of #563, which were a different manifestation of the same kind of problem.