Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ties checkbox #619

Merged
merged 3 commits into from Mar 19, 2020
Merged

add ties checkbox #619

merged 3 commits into from Mar 19, 2020

Conversation

kaalleen
Copy link
Collaborator

@kaalleen kaalleen commented Feb 22, 2020

Adds a "ties" checkbox to stroke params.
Cannot find the issue where it was requested right now...

@lexelby
Copy link
Member

lexelby commented Mar 5, 2020

Hmm... I wonder if maybe we should do this using a visual command instead, so that we can support all kinds of objects at once?

@kaalleen
Copy link
Collaborator Author

kaalleen commented Mar 5, 2020

Hm, looking at the code I would totally agree. But I think having it as a checkbox actually has an advantage: users can save their favorite method to the stitch preset without having to add commands to all the objects. They can easily select their own settings from the Params menu. What do you think?

@lexelby
Copy link
Member

lexelby commented Mar 5, 2020

That is a very good point! What if we put the ties param in EmbroideryElement so that all objects have it?

@kaalleen
Copy link
Collaborator Author

kaalleen commented Mar 7, 2020

What if we put the ties param in EmbroideryElement so that all objects have it?

Sounds good. I've included it there.

@lexelby
Copy link
Member

lexelby commented Mar 17, 2020

How about this, to avoid having to set stitch_as_is in every Element subclass?

@kaalleen kaalleen merged commit 6a012b6 into master Mar 19, 2020
4 checks passed
@kaalleen kaalleen deleted the add-ties-checkbox branch Mar 19, 2020
kaalleen added a commit that referenced this issue May 16, 2020
## New Features

- New Simulator (#531)
- Import Threadlist (#666)
- Export Threadlist in ZIP file (#664)
- Option to include SVG in ZIP file (#648)
- Break Apart and Retain Holes (#653)
- G-Code: option to alternate z-value (#659)
- New Stitch Plan Extension (#640)
- Optionally enable/disable ties (lock down stitches) (#619)
- Multiple Fill Underlays
- Additional Fonts (#683):
    * Geneva
    * DejaVu

## Improvements

- Better Algorithm for Satin Columns (#607)
- Better Algorithm for Fill Stitches (#606)
- Convert to Satin with Loops (#608)
- Adding '@ #' to all fonts (#680)

## Bug Fixes

- Fix Issue with Troubleshoot Pointer Position (#696)
- Inherit Styles (#673)
- Fix Color Palette Issues (#660)
- Preserve Aspect Ratio (#646)
- and more

## Under the Hood

- Namespaced Attributes (#657)
- Remove stub.py (#629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants